Page MenuHomeFreeBSD

tee: minor cleanup
AcceptedPublic

Authored by kevans on Dec 24 2024, 6:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 12, 1:30 AM
Unknown Object (File)
Sat, Feb 8, 10:44 PM
Unknown Object (File)
Sat, Feb 8, 2:31 AM
Unknown Object (File)
Thu, Feb 6, 3:43 AM
Unknown Object (File)
Tue, Jan 28, 6:53 AM
Unknown Object (File)
Jan 9 2025, 7:22 PM
Unknown Object (File)
Jan 9 2025, 6:56 PM
Unknown Object (File)
Jan 9 2025, 8:05 AM
Subscribers

Details

Reviewers
des
emaste
asomers
ngie
Group Reviewers
tests
Summary

Pull the open flags out of the loop into a local var. They won't be
changing, so this is marginally more readable.

Adds some extra brackets around the loop in preparation for a future
change that may try to fallback to opening the path as a socket if we
get an EOPNOTSUPP.

No functional change.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61322
Build 58206: arc lint + arc unit

Event Timeline

kevans added a parent revision: D48195: tee: add some basic tests.
This revision is now accepted and ready to land.Dec 24 2024, 10:12 PM

I think the added braces are an improvement even absent the subsequent change.

des added inline comments.
usr.bin/tee/tee.c
64

I would merge the two int lines and the two char * lines.

102

I'd prefer braces around this line.

kevans added inline comments.
usr.bin/tee/tee.c
64

Also re-sorted