Page MenuHomeFreeBSD

tee: minor cleanup
ClosedPublic

Authored by kevans on Dec 24 2024, 6:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 29, 10:07 AM
Unknown Object (File)
Sep 17 2025, 5:02 AM
Unknown Object (File)
Sep 13 2025, 6:33 PM
Unknown Object (File)
Sep 13 2025, 1:44 PM
Unknown Object (File)
Sep 13 2025, 1:18 PM
Unknown Object (File)
Sep 12 2025, 3:49 PM
Unknown Object (File)
Sep 9 2025, 7:23 PM
Unknown Object (File)
Sep 8 2025, 3:35 PM
Subscribers

Details

Summary

Pull the open flags out of the loop into a local var. They won't be
changing, so this is marginally more readable.

Adds some extra brackets around the loop in preparation for a future
change that may try to fallback to opening the path as a socket if we
get an EOPNOTSUPP.

No functional change.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans added a parent revision: D48195: tee: add some basic tests.
This revision is now accepted and ready to land.Dec 24 2024, 10:12 PM

I think the added braces are an improvement even absent the subsequent change.

des added inline comments.
usr.bin/tee/tee.c
62

I would merge the two int lines and the two char * lines.

100–102

I'd prefer braces around this line.

kevans added inline comments.
usr.bin/tee/tee.c
62

Also re-sorted

This revision was automatically updated to reflect the committed changes.
kevans marked an inline comment as done.