Page MenuHomeFreeBSD

tee: minor cleanup
ClosedPublic

Authored by kevans on Dec 24 2024, 6:11 PM.
Tags
None
Referenced Files
F165907042: D48196.id148378.diff
Mon, Aug 10, 11:35 AM
F165854323: D48196.id.diff
Mon, Aug 10, 7:01 AM
F165849996: D48196.id153963.diff
Mon, Aug 10, 6:25 AM
Unknown Object (File)
Sat, Aug 8, 5:54 PM
Unknown Object (File)
Sat, Aug 8, 5:11 AM
Unknown Object (File)
Fri, Aug 7, 6:30 PM
Unknown Object (File)
Fri, Aug 7, 3:51 PM
Unknown Object (File)
Tue, Jul 28, 11:10 AM
Subscribers

Details

Summary

Pull the open flags out of the loop into a local var. They won't be
changing, so this is marginally more readable.

Adds some extra brackets around the loop in preparation for a future
change that may try to fallback to opening the path as a socket if we
get an EOPNOTSUPP.

No functional change.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans added a parent revision: D48195: tee: add some basic tests.
This revision is now accepted and ready to land.Dec 24 2024, 10:12 PM

I think the added braces are an improvement even absent the subsequent change.

des added inline comments.
usr.bin/tee/tee.c
62

I would merge the two int lines and the two char * lines.

100–102

I'd prefer braces around this line.

kevans added inline comments.
usr.bin/tee/tee.c
62

Also re-sorted

This revision was automatically updated to reflect the committed changes.
kevans marked an inline comment as done.