Page MenuHomeFreeBSD
Differential D48196

tee: minor cleanup
ClosedPublic
Actions

Authored by kevans on Dec 24 2024, 6:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Aug 30, 12:06 PM
Unknown Object (File)
Sun, Aug 30, 10:01 AM
Unknown Object (File)
Sun, Aug 30, 9:08 AM
Unknown Object (File)
Sun, Aug 30, 8:36 AM
Unknown Object (File)
Tue, Aug 25, 8:12 PM
Unknown Object (File)
Tue, Aug 25, 1:18 PM
Unknown Object (File)
Tue, Aug 25, 11:40 AM
Unknown Object (File)
Tue, Aug 25, 11:36 AM
View All Files
Subscribers
imp

Details

Reviewers
des
emaste
asomers
ngie
Group Reviewers
tests
Commits
rG414c2b8d1e5a: tee: minor cleanup
Summary

Pull the open flags out of the loop into a local var. They won't be
changing, so this is marginally more readable.

Adds some extra brackets around the loop in preparation for a future
change that may try to fallback to opening the path as a socket if we
get an EOPNOTSUPP.

No functional change.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans created this revision.Dec 24 2024, 6:11 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 24 2024, 6:11 PM
kevans requested review of this revision.Dec 24 2024, 6:11 PM
kevans added a parent revision: D48195: tee: add some basic tests.
Harbormaster completed remote builds in B61321: Diff 148375.Dec 24 2024, 6:11 PM
kevans updated this revision to Diff 148378.Dec 24 2024, 10:06 PM

omode -> oflags

Harbormaster completed remote builds in B61322: Diff 148378.Dec 24 2024, 10:06 PM
asomers accepted this revision.Dec 24 2024, 10:12 PM
This revision is now accepted and ready to land.Dec 24 2024, 10:12 PM
kevans added a child revision: D48197: tee: try opening as a UNIX socket if open(2) fails.Dec 24 2024, 10:30 PM
emaste accepted this revision.Dec 25 2024, 2:43 AM

I think the added braces are an improvement even absent the subsequent change.

ngie accepted this revision.Dec 25 2024, 6:42 PM
des accepted this revision.Dec 26 2024, 1:35 PM
des added inline comments.
usr.bin/tee/tee.c
62

I would merge the two int lines and the two char * lines.

100–102

I'd prefer braces around this line.

kevans marked 2 inline comments as done.Dec 27 2024, 4:10 AM
kevans added inline comments.
usr.bin/tee/tee.c
62

Also re-sorted

Closed by commit rG414c2b8d1e5a: tee: minor cleanup (authored by kevans). · Explain WhyApr 20 2025, 4:36 PM
This revision was automatically updated to reflect the committed changes.
kevans marked an inline comment as done.
kevans added a commit: rG414c2b8d1e5a: tee: minor cleanup.

Revision Contents
Changeset List

PathSize
usr.bin/
tee/
21 lines

Diff 153963

View Options

usr.bin/tee/tee.c

Loading...