Page MenuHomeFreeBSD

tee: minor cleanup
ClosedPublic

Authored by kevans on Dec 24 2024, 6:11 PM.
Tags
None
Referenced Files
F144441099: D48196.id153963.diff
Sun, Feb 8, 11:19 AM
F144360330: D48196.id148375.diff
Sun, Feb 8, 1:16 AM
F144306769: D48196.id148378.diff
Sat, Feb 7, 6:29 PM
Unknown Object (File)
Sat, Jan 31, 3:33 PM
Unknown Object (File)
Sat, Jan 31, 12:47 PM
Unknown Object (File)
Sat, Jan 31, 7:34 AM
Unknown Object (File)
Sun, Jan 18, 7:45 AM
Unknown Object (File)
Sat, Jan 17, 5:43 PM
Subscribers

Details

Summary

Pull the open flags out of the loop into a local var. They won't be
changing, so this is marginally more readable.

Adds some extra brackets around the loop in preparation for a future
change that may try to fallback to opening the path as a socket if we
get an EOPNOTSUPP.

No functional change.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans added a parent revision: D48195: tee: add some basic tests.
This revision is now accepted and ready to land.Dec 24 2024, 10:12 PM

I think the added braces are an improvement even absent the subsequent change.

des added inline comments.
usr.bin/tee/tee.c
62

I would merge the two int lines and the two char * lines.

100–102

I'd prefer braces around this line.

kevans added inline comments.
usr.bin/tee/tee.c
62

Also re-sorted

This revision was automatically updated to reflect the committed changes.
kevans marked an inline comment as done.