mlx5en: Allow RX and TX pause frames to be set through ifconfig
ClosedPublic
Actions

Authored by markb_mellanox.com on Jan 7 2016, 2:34 PM.

Details

Reviewers

erj
• hselasky
np
gnn

Commits

rS294917: MFC r294314:
rS294314: Allow RX and TX pause frames to be set through ifconfig.

Summary

Allow setting RX/TX pause frames via ifconfig

Submitted by: Hans Petter Selasky <hps@selasky.org>
Sponsored by: Mellanox Technologies

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

markb_mellanox.com updated this revision to Diff 11998.Jan 7 2016, 2:34 PM

markb_mellanox.com retitled this revision from to mlx5en: Allow RX and TX pause frames to be set through ifconfig.

markb_mellanox.com updated this object.

markb_mellanox.com edited the test plan for this revision. (Show Details)

markb_mellanox.com added reviewers: gnn, • hselasky, np, erj.

markb_mellanox.com set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptJan 7 2016, 2:34 PM

markb_mellanox.com added a subscriber: gallatin.Jan 7 2016, 2:35 PM

I may be misreading this, but it appears we are loosing the ability to set the initial pause state via a loader tunable. Would it be possible to preserve this feature by masking the IFM_ETHER_*PAUSE bits with the user's desired pause sate in the initial ifmedia_set() call?

Yes, this patch removes the sysctl way to set RX/TX pause frames. It is possible to have both sysctl and ifconfig.