Page MenuHomeFreeBSD

Makefile.inc1: Remove non-NO_ROOT cases from distributeworld
ClosedPublic

Authored by emaste on Dec 15 2024, 9:53 PM.
Tags
None
Referenced Files
F151271285: D48095.id147995.diff
Tue, Apr 7, 5:56 AM
Unknown Object (File)
Thu, Mar 26, 3:55 AM
Unknown Object (File)
Mon, Mar 23, 9:32 AM
Unknown Object (File)
Sun, Mar 22, 7:48 AM
Unknown Object (File)
Sun, Mar 22, 7:48 AM
Unknown Object (File)
Sun, Mar 22, 7:48 AM
Unknown Object (File)
Sat, Mar 21, 10:14 AM
Unknown Object (File)
Feb 8 2026, 10:12 AM
Subscribers

Details

Summary
As of commit 41adc5f29ba6 ("release: Always use NO_ROOT for distribute*
and package*") we pass -NO_ROOT for the release image artifact build
targets.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.

I wouldn't be surprised if we find some cases where people have to adapt to this change, but I think it's the right one. Eventually we might even want to forbid root entirely for this target, but that may be a bridge too far.

Makefile.inc1
1006

..?

This revision is now accepted and ready to land.Dec 16 2024, 9:22 PM

I wouldn't be surprised if we find some cases where people have to adapt to this change, but I think it's the right one.

Yes - it just enforces what we always set in release/Makefile now, but indeed there may be downstream users of our build infrastructure that will need to adapt. I should send a note to appropriate mailing list(s) about unprivileged and reproducible builds and NO_ROOT.

Eventually we might even want to forbid root entirely for this target, but that may be a bridge too far.

We could at least emit a warning that running this target at root is not recommended.