tcp: cleanup of nits after use of accessor tcp_get_flags
ClosedPublic
Actions

Authored by rscheff on Dec 12 2024, 11:37 PM.

Details

Reviewers

tuexen
cc
gnn
cy

Commits

rG31034044ff27: tcp: cleanup of nits after use of accessor tcp_get_flags

Summary

Remove unneeded th_x2 initalization, use named constants
instead of magic numbers (fixing one oversight) and add
some line breaks. Expand one man page slightly.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 61131
Build 58015: arc lint + arc unit

Event Timeline

rscheff created this revision.Dec 12 2024, 11:37 PM

Herald added a reviewer: gnn. · View Herald TranscriptDec 12 2024, 11:37 PM

Herald added a reviewer: cy. · View Herald Transcript

Herald added a subscriber: imp. · View Herald Transcript

rscheff requested review of this revision.Dec 12 2024, 11:37 PM

Harbormaster completed remote builds in B61131: Diff 147901.Dec 12 2024, 11:37 PM

update man to match code

Harbormaster completed remote builds in B61132: Diff 147902.Dec 12 2024, 11:41 PM

tuexen accepted this revision.Dec 18 2024, 4:46 PM

This revision is now accepted and ready to land.Dec 18 2024, 4:46 PM

cc accepted this revision.Dec 18 2024, 5:19 PM

Closed by commit rG31034044ff27: tcp: cleanup of nits after use of accessor tcp_get_flags (authored by rscheff). · Explain WhyDec 19 2024, 3:39 PM

This revision was automatically updated to reflect the committed changes.

rscheff added a commit: rG31034044ff27: tcp: cleanup of nits after use of accessor tcp_get_flags.

Revision Contents
Changeset List

Path

Size

cddl/

lib/

libdtrace/

tcp.d

4 lines

sbin/

ipf/

iplang/

iplang_y.y

3 lines

ipsend/

2 lines

2 lines

3 lines

2 lines

libipf/

ipft_tx.c

10 lines

printpacket.c

4 lines

usr.sbin/

ppp/

ip.c

4 lines

Diff 147901

View Options

cddl/lib/libdtrace/tcp.d

View Options

sbin/ipf/iplang/iplang_y.y

View Options

sbin/ipf/ipsend/ipsend.1

View Options

sbin/ipf/ipsend/ipsend.c

View Options

sbin/ipf/ipsend/iptests.c

View Options

sbin/ipf/ipsend/resend.c

View Options

sbin/ipf/libipf/ipft_tx.c

View Options

sbin/ipf/libipf/printpacket.c

View Options

tcp: cleanup of nits after use of accessor tcp_get_flagsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 147901

cddl/lib/libdtrace/tcp.d

sbin/ipf/iplang/iplang_y.y

sbin/ipf/ipsend/ipsend.1

sbin/ipf/ipsend/ipsend.c

sbin/ipf/ipsend/iptests.c

sbin/ipf/ipsend/resend.c

sbin/ipf/libipf/ipft_tx.c

sbin/ipf/libipf/printpacket.c

usr.sbin/ppp/ip.c

tcp: cleanup of nits after use of accessor tcp_get_flags
ClosedPublic
Actions

Revision Contents
Changeset List