Clean pkg cache after installing wifi-firmware-kmod-release in release media 14.2

[bofh]

Summary

Recently, we have added the wifi-firmware-kmod-release pkgs in the release installation media, but unfortunately, the pkgs are not cleaned up after the installation, keeping the pkgs in the cache. The pkgs should be removed with pkg clean.

Also look at the bug report:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283112

MFC after: 3 days/immediate (before next snapshot)

[lwhsu]

That's a good catch, and not sure if we also want to remove the repo data in the cache and unregister the pkg itself like what we do in VM. Having those might cause an issue when pkg is boostraped but repo data is seriously out-of-date. We encountered this in the past in the cloud images.

[lwhsu]

In D47942#1093167, @lwhsu wrote:

That's a good catch, and not sure if we also want to remove the repo data in the cache and unregister the pkg itself like what we do in VM. Having those might cause an issue when pkg is boostraped but repo data is seriously out-of-date. We encountered this in the past in the cloud images.

Forgot to attach the reference: https://github.com/freebsd/freebsd-src/blob/main/release/tools/ec2.conf#L27-L30

[emaste]

want to remove the repo data in the cache and unregister the pkg itself like what we do in VM

Perhaps, but I think this issue is fundamentally different than the VM case and I would suggest we both make this (D47942) change and MFC it as soon as we can, and consider following up with further changes.

[lwhsu]

In D47942#1093222, @emaste wrote:

want to remove the repo data in the cache and unregister the pkg itself like what we do in VM

Perhaps, but I think this issue is fundamentally different than the VM case and I would suggest we both make this (D47942) change and MFC it as soon as we can, and consider following up with further changes.

Yes I don't mean to stop merging this (I didn't set to "request changes"). Just wanted to provide more related information...

[bz]

I am still contemplating if we should simply put the cache-dir outside the

I assume what pkg-clean calls PKG_CONFIG_CACHEDIR pkg-install calls PKG_CACHEDIR and given we don't chroot (unless pkg -r does that implicitly) we could just put the CACHEDIR somewhere else into obj.

But yes, get this in first and refine later is probably a good approach; I never got an answer from @brd who, as @cperciva said, had figured this all out for pkg-base already?

[bz]

@bofh are you going to commit this?

[bofh]

In D47942#1094365, @bz wrote:

@bofh are you going to commit this?

To be frank, although I wear a re@ hat, we have strict directives from @cperciva not to commit to /release without his approval. As he is in AWS REINVENT for now; I am not sure how this works. :(

[bz]

In D47942#1094368, @bofh wrote:

In D47942#1094365, @bz wrote:

@bofh are you going to commit this?

To be frank, although I wear a re@ hat, we have strict directives from @cperciva not to commit to /release without his approval. As he is in AWS REINVENT for now; I am not sure how this works. :(

Okay. I assume it's that automated snapshots etc. do not break. He should be back any day now I hope, let's see. I am just trying to wrap up lose ends before traveling as well ;-)

[emaste]

It would be very good to get this committed (to main) before this week's snapshots

[cperciva]

LGTM