Page MenuHomeFreeBSD

comsat: Use initgroups and setgid not just setuid
ClosedPublic

Authored by emaste on Nov 28 2024, 4:56 PM.
Tags
None
Referenced Files
F132406983: D47828.id147125.diff
Thu, Oct 16, 4:24 PM
Unknown Object (File)
Wed, Oct 15, 2:14 AM
Unknown Object (File)
Fri, Sep 19, 7:56 AM
Unknown Object (File)
Wed, Sep 17, 5:05 PM
Unknown Object (File)
Sep 16 2025, 5:05 PM
Unknown Object (File)
Sep 12 2025, 3:05 AM
Unknown Object (File)
Sep 11 2025, 5:16 PM
Unknown Object (File)
Sep 10 2025, 4:30 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.
jlduran added inline comments.
libexec/comsat/comsat.c
214–215

I would suggest also updating this comment

This revision is now accepted and ready to land.Nov 29 2024, 10:21 PM

One thing I've noticed is that NetBSD moved the setting of groups/uid/gid earlier to inside notify() (https://github.com/NetBSD/src/commit/46b017828cee516770586497237aed6182b1decf). I think failing earlier is also a good move.

One thing I've noticed is that NetBSD moved the setting of groups/uid/gid earlier to inside notify() (https://github.com/NetBSD/src/commit/46b017828cee516770586497237aed6182b1decf). I think failing earlier is also a good move.

Not a bad idea, can follow up with that (and check for any other improvements from NetBSD or OpenBSD)