Page MenuHomeFreeBSD

comsat: Use initgroups and setgid not just setuid
ClosedPublic

Authored by emaste on Thu, Nov 28, 4:56 PM.
Tags
None
Referenced Files
F104251876: D47828.diff
Thu, Dec 5, 9:29 AM
Unknown Object (File)
Tue, Dec 3, 3:30 PM
Unknown Object (File)
Sun, Dec 1, 8:31 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.
jlduran added inline comments.
libexec/comsat/comsat.c
214–215

I would suggest also updating this comment

This revision is now accepted and ready to land.Fri, Nov 29, 10:21 PM

One thing I've noticed is that NetBSD moved the setting of groups/uid/gid earlier to inside notify() (https://github.com/NetBSD/src/commit/46b017828cee516770586497237aed6182b1decf). I think failing earlier is also a good move.

One thing I've noticed is that NetBSD moved the setting of groups/uid/gid earlier to inside notify() (https://github.com/NetBSD/src/commit/46b017828cee516770586497237aed6182b1decf). I think failing earlier is also a good move.

Not a bad idea, can follow up with that (and check for any other improvements from NetBSD or OpenBSD)