pf: update pd->tot_len after reassembly
ClosedPublic
Actions

Authored by kp on Nov 27 2024, 4:44 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 25, 8:54 PM

	Unknown Object (File)
	Sat, Nov 8, 2:46 AM

	Unknown Object (File)
	Wed, Nov 5, 4:03 AM

	Unknown Object (File)
	Sun, Nov 2, 12:17 PM

	Unknown Object (File)
	Sat, Nov 1, 7:52 PM

	Unknown Object (File)
	Oct 12 2025, 2:59 AM

	Unknown Object (File)
	Sep 14 2025, 10:05 PM

	Unknown Object (File)
	Sep 13 2025, 12:07 AM

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

None

Group Reviewers

pfsense
network

Commits

rG6c5c91a039c7: pf: update pd->tot_len after reassembly

Summary

Ensure that the packet length we track in struct pf_pdesc matches the
reassembled packet size.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Nov 27 2024, 4:44 PM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptNov 27 2024, 4:44 PM

kp requested review of this revision.Nov 27 2024, 4:44 PM

Harbormaster completed remote builds in B60837: Diff 147062.Nov 27 2024, 4:44 PM

kp added a parent revision: D47802: pf tests: verify that we preserve the hop limit/TTL for ICMP errors.Nov 27 2024, 4:44 PM

kp added a child revision: D47804: pf: handle fragmentation for nat64.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 17 2024, 10:10 AM

Closed by commit rG6c5c91a039c7: pf: update pd->tot_len after reassembly (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG6c5c91a039c7: pf: update pd->tot_len after reassembly.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf_norm.c

4 lines

Diff 148156

View Options

pf: update pd->tot_len after reassemblyClosedPublicActions