sound: Dissolve pcm/intpcm.h

[christos]

Summary

Part of a series of patches to cleanup/simplify pcm/.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

[christos]

sys/dev/sound/pcm/feeder_format.c

104

I am trying to come up with a cleaner design for these. As mentioned in the commit message, this is part of a series of patches.

[dev_submerge.ch]

If we do further work on the conversion functions, we may want to unit test them. Is that possible when we integrate them in feeder_format.c? I suppose a separate header would be easier, less extra dependencies?

[christos]

In D47736#1089471, @dev_submerge.ch wrote:

If we do further work on the conversion functions, we may want to unit test them. Is that possible when we integrate them in feeder_format.c? I suppose a separate header would be easier, less extra dependencies?

Perhaps it could be useful, but I think it's better to first decide on the design and then implement the new header. I would like to somehow avoid the macro magic. :)

[dev_submerge.ch]

In D47736#1089562, @christos wrote:

In D47736#1089471, @dev_submerge.ch wrote:

If we do further work on the conversion functions, we may want to unit test them. Is that possible when we integrate them in feeder_format.c? I suppose a separate header would be easier, less extra dependencies?

Perhaps it could be useful, but I think it's better to first decide on the design and then implement the new header. I would like to somehow avoid the macro magic. :)

It's not exactly clear to me what you want to achieve. But you could replace some macro and table parts with a function that takes the AFMT_* as a parameter, just make sure the function is inlined and always called with a literal as the format parameter. Although that may result in a performance hit for debug builds, I didn't look at all the details yet.