Page MenuHomeFreeBSD

ipfilter: Don't reinitialize lock in timer function
AbandonedPublic

Authored by cy on Nov 12 2024, 3:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 4, 12:39 AM
Unknown Object (File)
Nov 24 2025, 8:29 PM
Unknown Object (File)
Nov 14 2025, 6:33 AM
Unknown Object (File)
Nov 9 2025, 7:42 AM
Unknown Object (File)
Oct 29 2025, 12:34 PM
Unknown Object (File)
Oct 29 2025, 12:33 PM
Unknown Object (File)
Oct 29 2025, 12:12 PM
Unknown Object (File)
Oct 29 2025, 12:11 PM

Details

Reviewers
markj
emaste
Summary

This is unnecessary and may result in a deadlock.

Fixes: 1fa6daaafd74

Test Plan

I will test on my firewall here at home.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

cy requested review of this revision.Nov 12 2024, 3:42 PM

This is not sufficient to fix the referenced commit, it'll still deadlock after this change.

The problem is that callout_init_rw() causes the callout framework to acquire the rwlock before executing the timeout function, and that timeout function will try to acquire it again.