pf: Fix a use of an uninitialized variable
ClosedPublic
Actions

Authored by markj on Nov 2 2024, 7:58 PM.

Details

Reviewers

Commits

rG4ee6a830d6c1: pf: Fix a use of an uninitialized variable

Summary

pf_find_state_all() expects the caller to initialize "*more" if it is
non-NULL.

Reported by: KMSAN

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Nov 2 2024, 7:58 PM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptNov 2 2024, 7:58 PM

markj requested review of this revision.Nov 2 2024, 7:58 PM

Harbormaster completed remote builds in B60349: Diff 145895.Nov 2 2024, 7:59 PM

Should we add MPASS(more == NULL || *more == 0) in pf_find_state_all()?

This revision is now accepted and ready to land.Nov 3 2024, 1:56 PM

In D47405#1081320, @kp wrote:

Should we add MPASS(more == NULL || *more == 0) in pf_find_state_all()?

On reflection, I think we should fix this by having pf_find_staye_all() initialise *more to 0, because if we don’t find anything that’s the correct thing to return.

In D47405#1081337, @kp wrote:

In D47405#1081320, @kp wrote:

Should we add MPASS(more == NULL || *more == 0) in pf_find_state_all()?

On reflection, I think we should fix this by having pf_find_staye_all() initialise *more to 0, because if we don’t find anything that’s the correct thing to return.

Yeah, I was just about to make that change. I think all callers should initialize *more = 0 to avoid extra diffs with OpenBSD, but pf_find_state_all() should also be careful to initialize *more.