Differential D47154

device_delete_child: Update comments
ClosedPublic
Actions

Authored by jhb on Oct 16 2024, 3:27 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 1, 6:59 AM

	Unknown Object (File)
	Sat, Nov 30, 11:28 AM

	Unknown Object (File)
	Fri, Nov 29, 2:06 PM

	Unknown Object (File)
	Mon, Nov 25, 10:43 AM

	Unknown Object (File)
	Wed, Nov 20, 4:51 PM

	Unknown Object (File)
	Wed, Nov 6, 4:20 PM

	Unknown Object (File)
	Oct 27 2024, 11:09 AM

	Unknown Object (File)
	Oct 20 2024, 9:44 PM

View All 16 Files

Subscribers

Details

Reviewers

Commits

rG664491911597: device_delete_child: Update comments
rGbce5607513fa: device_delete_child: Update comments
rG1ad335196656: device_delete_child: Update comments

Summary

This better matches the variable names and the function comment as
well as clarifying the reason for the order of operations.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60041
Build 56925: arc lint + arc unit

Event Timeline

jhb created this revision.Oct 16 2024, 3:27 PM

Herald added a subscriber: olce. · View Herald TranscriptOct 16 2024, 3:27 PM

jhb requested review of this revision.Oct 16 2024, 3:27 PM

Harbormaster completed remote builds in B60041: Diff 144994.Oct 16 2024, 3:27 PM

jhb added a child revision: D47155: device_attach: Invoke BUS_CHILD_DETACHED if an attach routine fails.Oct 16 2024, 3:27 PM

imp accepted this revision.Oct 16 2024, 3:34 PM

This revision is now accepted and ready to land.Oct 16 2024, 3:34 PM

Closed by commit rG1ad335196656: device_delete_child: Update comments (authored by jhb). · Explain WhyOct 16 2024, 6:10 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG1ad335196656: device_delete_child: Update comments.

jhb added a commit: rGbce5607513fa: device_delete_child: Update comments.Sun, Dec 1, 4:57 AM

jhb added a commit: rG664491911597: device_delete_child: Update comments.

Revision Contents
Changeset List

Path

Size

sys/

kern/

7 lines

Diff 144994

sys/kern/subr_bus.c

Loading...