Paths

Table of Contentst

divapp.c
ClosedPublic
Actions

Authored by igoro on Oct 15 2024, 5:24 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jan 13, 6:02 AM

	Unknown Object (File)
	Thu, Dec 26, 11:43 AM

	Unknown Object (File)
	Wed, Dec 25, 2:00 PM

	Unknown Object (File)
	Dec 11 2024, 10:05 AM

	Unknown Object (File)
	Dec 10 2024, 11:25 PM

	Unknown Object (File)
	Nov 30 2024, 7:45 PM

	Unknown Object (File)
	Nov 21 2024, 11:24 AM

	Unknown Object (File)
	Nov 19 2024, 10:33 PM

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

kp
markj

Commits

rGb3e7d4b67ce6: tests: Fix style of netpfil/common/divapp.c

Summary

No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60033
Build 56917: arc lint + arc unit

Event Timeline

igoro created this revision.Oct 15 2024, 5:24 PM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro, imp. · View Herald TranscriptOct 15 2024, 5:24 PM

igoro requested review of this revision.Oct 15 2024, 5:24 PM

Harbormaster completed remote builds in B60015: Diff 144934.Oct 15 2024, 5:24 PM

markj added inline comments.Oct 15 2024, 8:27 PM

tests/sys/netpfil/common/divapp.c
104	If you use `err()` instead of `errx()`, information from `errno` will be appended automatically.

Use the standard way for error reporting

Harbormaster completed remote builds in B60033: Diff 144984.Oct 16 2024, 10:27 AM

igoro marked an inline comment as done.Oct 16 2024, 10:28 AM

igoro added inline comments.

tests/sys/netpfil/common/divapp.c
104	Nice, thanks.

Approved.

This revision is now accepted and ready to land.Oct 16 2024, 1:02 PM

Closed by commit rGb3e7d4b67ce6: tests: Fix style of netpfil/common/divapp.c (authored by igoro). · Explain WhyOct 16 2024, 4:26 PM

This revision was automatically updated to reflect the committed changes.

igoro marked an inline comment as done.

igoro added a commit: rGb3e7d4b67ce6: tests: Fix style of netpfil/common/divapp.c.

Revision Contents
Changeset List

Path

Size

tests/

sys/

netpfil/

common/

divapp.c

13 lines

Diff 144984

View Options

tests/sys/netpfil/common/divapp.c

tests: Fix style of netpfil/common/divapp.cClosedPublicActions