vm_glue: use vm_page_alloc_domain_after
ClosedPublic
Actions

Authored by dougm on Oct 11 2024, 7:24 AM.

Details

Reviewers

alc
bnovkov

Commits

rG6d42d5dbdd67: vm_glue: use vm_page_alloc_domain_after

Summary

Drop the function vm_page_alloc_domain, used only in vm_thread_stack_back, and replace it with vm_page_alloc_domain_after there, with the extra mpred argument either computed on the first iteration or retrieved from previous iterations. Define a function vm_page_mpred() for computing that first mpred argument.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dougm requested review of this revision.Oct 11 2024, 7:24 AM

dougm created this revision.

bnovkov added a subscriber: bnovkov.Oct 12 2024, 4:17 PM

This change looks good to me, having a lookup routine explicitly intended for 'mpred' is really nice as well.

This revision is now accepted and ready to land.Oct 12 2024, 4:54 PM

Closed by commit rG6d42d5dbdd67: vm_glue: use vm_page_alloc_domain_after (authored by dougm). · Explain WhyOct 19 2024, 8:25 PM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rG6d42d5dbdd67: vm_glue: use vm_page_alloc_domain_after.

Herald added a subscriber: imp. · View Herald TranscriptOct 19 2024, 8:25 PM

markj added a subscriber: markj.Oct 19 2024, 11:15 PM

markj added inline comments.

sys/vm/vm_page.c
2025	The function which would logically be called vm_page_msucc() already exists and is called vm_page_find_least(). I don't have strong feelings about which name is better, but it would be good to be consistent.