Paths

Table of Contentst

Differential D46983

pkg(7): improve error message
ClosedPublic
Actions

Authored by emaste on Mon, Oct 7, 3:47 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

bdrewery
bapt

Commits

rGbe9243409d6b: pkg: improve error message

Summary

Print the complete list of url that have failed

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bapt created this revision.Mon, Oct 7, 3:47 PM

Herald added a reviewer: bdrewery. · View Herald TranscriptMon, Oct 7, 3:47 PM

Herald added a subscriber: imp. · View Herald Transcript

bapt requested review of this revision.Mon, Oct 7, 3:47 PM

Harbormaster completed remote builds in B59812: Diff 144400.Mon, Oct 7, 3:47 PM

0mp added a subscriber: 0mp.Mon, Oct 7, 3:53 PM

0mp added inline comments.

usr.sbin/pkg/pkg.c
860	Am I reading it wrong or `j` is not used anywhere inside the loop?

fix issue reported by @0mp

Harbormaster completed remote builds in B59813: Diff 144404.Mon, Oct 7, 4:05 PM

bapt marked an inline comment as done.Mon, Oct 7, 4:05 PM

emaste added inline comments.Mon, Oct 7, 4:06 PM

usr.sbin/pkg/pkg.c
860	Yes this is a bug. It's also possible that the two entries failed for different reasons, and fetchLastErrString does not apply to the first.

there are good chances they do apply ;)

usr.sbin/pkg/pkg.c
860	yes the error might be different but the chances they are the same are imho good enough for now.

emaste added inline comments.Mon, Oct 7, 4:29 PM

usr.sbin/pkg/pkg.c
860	Yes fair enough, they are probably the same. If we wanted to be precise we could emit: Attempted to fetch .... Attempted to fetch ... Error: ...

print one error message at end

Sample output:

The package management tool is not yet installed on your system.
Do you want to fetch and install it now? [y/N]: yes
Bootstrapping pkg from pkg+http://pkg.FreeBSD.org/FreeBSD:15:amd64/latest, please wait...
pkg: Attempted to fetch http://pkg.FreeBSD.org/FreeBSD:15:amd64/latest/Latest/pkg.pkg
pkg: Attempted to fetch http://pkg.FreeBSD.org/FreeBSD:15:amd64/latest/Latest/pkg.txz
pkg: Error: Host does not resolve
Address resolution failed for http://pkg.FreeBSD.org/FreeBSD:15:amd64/latest.
Consider changing PACKAGESITE.

emaste mentioned this in D46981: pkg: Retry the default name for better error if all fail.Mon, Oct 7, 4:42 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Oct 7, 5:06 PM

Closed by commit rGbe9243409d6b: pkg: improve error message (authored by emaste). · Explain Why

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGbe9243409d6b: pkg: improve error message.

Revision Contents
Changeset List

Path

Size

usr.sbin/

pkg/

6 lines

Diff 144425

usr.sbin/pkg/pkg.c

Loading...