Page MenuHomeFreeBSD
Differential D46983

pkg(7): improve error message
ClosedPublic
Actions

Authored by emaste on Oct 7 2024, 3:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 9:06 AM
Unknown Object (File)
Tue, Nov 19, 6:01 PM
Unknown Object (File)
Tue, Nov 19, 6:49 AM
Unknown Object (File)
Sun, Nov 17, 4:19 PM
Unknown Object (File)
Fri, Nov 15, 2:55 PM
Unknown Object (File)
Wed, Nov 6, 12:16 PM
Unknown Object (File)
Tue, Nov 5, 1:36 PM
Unknown Object (File)
Wed, Oct 30, 8:14 AM
View All 19 Files
Subscribers
0mp
imp

Details

Reviewers
bdrewery
bapt
Commits
rG40b58e3183ac: pkg: improve error message
rG2f29060f4613: pkg: improve error message
rGbe9243409d6b: pkg: improve error message
Summary

Print the complete list of url that have failed

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59813
Build 56698: arc lint + arc unit

Event Timeline

bapt created this revision.Oct 7 2024, 3:47 PM
Herald added a reviewer: bdrewery. · View Herald TranscriptOct 7 2024, 3:47 PM
Herald added a subscriber: imp. · View Herald Transcript
bapt requested review of this revision.Oct 7 2024, 3:47 PM
Harbormaster completed remote builds in B59812: Diff 144400.Oct 7 2024, 3:47 PM
0mp added a subscriber: 0mp.Oct 7 2024, 3:53 PM
0mp added inline comments.
usr.sbin/pkg/pkg.c
860

Am I reading it wrong or j is not used anywhere inside the loop?

bapt updated this revision to Diff 144404.Oct 7 2024, 4:05 PM

fix issue reported by @0mp

Harbormaster completed remote builds in B59813: Diff 144404.Oct 7 2024, 4:05 PM
bapt marked an inline comment as done.Oct 7 2024, 4:05 PM
emaste added inline comments.Oct 7 2024, 4:06 PM
usr.sbin/pkg/pkg.c
860

Yes this is a bug. It's also possible that the two entries failed for different reasons, and fetchLastErrString does not apply to the first.

bapt marked an inline comment as done.Oct 7 2024, 4:26 PM

there are good chances they do apply ;)

usr.sbin/pkg/pkg.c
860

yes the error might be different but the chances they are the same are imho good enough for now.

emaste added inline comments.Oct 7 2024, 4:29 PM
usr.sbin/pkg/pkg.c
860

Yes fair enough, they are probably the same. If we wanted to be precise we could emit:

Attempted to fetch ....
Attempted to fetch ...
Error: ...
emaste commandeered this revision.Oct 7 2024, 4:38 PM
emaste updated this revision to Diff 144416.
emaste edited reviewers, added: bapt; removed: emaste.

print one error message at end

emaste added a comment.Oct 7 2024, 4:39 PM

Sample output:

The package management tool is not yet installed on your system.
Do you want to fetch and install it now? [y/N]: yes
Bootstrapping pkg from pkg+http://pkg.FreeBSD.org/FreeBSD:15:amd64/latest, please wait...
pkg: Attempted to fetch http://pkg.FreeBSD.org/FreeBSD:15:amd64/latest/Latest/pkg.pkg
pkg: Attempted to fetch http://pkg.FreeBSD.org/FreeBSD:15:amd64/latest/Latest/pkg.txz
pkg: Error: Host does not resolve
Address resolution failed for http://pkg.FreeBSD.org/FreeBSD:15:amd64/latest.
Consider changing PACKAGESITE.
emaste mentioned this in D46981: pkg: Retry the default name for better error if all fail.Oct 7 2024, 4:42 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 7 2024, 5:06 PM
Closed by commit rGbe9243409d6b: pkg: improve error message (authored by emaste). · Explain Why
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rGbe9243409d6b: pkg: improve error message.
emaste added a commit: rG2f29060f4613: pkg: improve error message.Oct 11 2024, 3:28 PM
emaste added a commit: rG40b58e3183ac: pkg: improve error message.Oct 11 2024, 4:18 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
pkg/
5 lines

Diff 144404

View Options

usr.sbin/pkg/pkg.c

Loading...