Page MenuHomeFreeBSD
Differential D4693

Add interrupt counter
ClosedPublic
Actions

Authored by howard0su_gmail.com on Dec 23 2015, 5:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 15 2024, 5:01 PM
Unknown Object (File)
Mar 15 2024, 5:01 PM
Unknown Object (File)
Jan 24 2024, 2:42 PM
Unknown Object (File)
Jan 4 2024, 5:53 PM
Unknown Object (File)
Jan 4 2024, 5:53 PM
Unknown Object (File)
Jan 4 2024, 5:53 PM
Unknown Object (File)
Jan 4 2024, 5:50 PM
Unknown Object (File)
Jan 4 2024, 5:50 PM
View All 92 Files
Subscribers
adrian
imp

Details

Reviewers
decui_microsoft.com
delphij
sepherosa_gmail.com
royger
adrian
Group Reviewers
Contributor Reviewers (ports)
Commits
rS293874: hyperv: add interrupt counters
Test Plan

systat, switch to vm tab
vmstat -i

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

howard0su_gmail.com updated this revision to Diff 11625.Dec 23 2015, 5:28 AM
howard0su_gmail.com retitled this revision from to Add interrupt counter.
howard0su_gmail.com updated this object.
howard0su_gmail.com edited the test plan for this revision. (Show Details)
Herald added a reviewer: Contributor Reviewers (ports). · View Herald TranscriptDec 23 2015, 5:28 AM
Herald added a subscriber: imp. · View Herald Transcript
howard0su_gmail.com updated this revision to Diff 11633.Dec 23 2015, 1:43 PM
howard0su_gmail.com edited edge metadata.

Remove debug code related to intr count in hv_connection

howard0su_gmail.com added reviewers: royger, delphij, decui_microsoft.com.Jan 7 2016, 2:14 AM
decui_microsoft.com accepted this revision.Jan 8 2016, 10:16 AM
decui_microsoft.com added a reviewer: sepherosa_gmail.com.
decui_microsoft.com edited edge metadata.

Looks good to me.

This revision is now accepted and ready to land.Jan 8 2016, 10:17 AM
royger accepted this revision.Jan 11 2016, 6:51 PM
royger edited edge metadata.

LGTM

sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c
224 ↗(On Diff #11633)

Isn't there a more suitable place to put those? Like at the top of the file?

howard0su_gmail.com updated this revision to Diff 12261.Jan 13 2016, 1:08 PM
howard0su_gmail.com edited edge metadata.

move variable to top of file and mark it as static.

This revision now requires review to proceed.Jan 13 2016, 1:08 PM
adrian added a subscriber: adrian.Jan 13 2016, 7:06 PM
adrian added inline comments.
sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c
69 ↗(On Diff #12261)

wait, it's a pointer; what's it pointing to?

howard0su_gmail.com added inline comments.Jan 13 2016, 11:57 PM
sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c
69 ↗(On Diff #12261)

it contains the pointer which was set via intrcnt_add,

adrian accepted this revision.Jan 14 2016, 12:43 AM
adrian added a reviewer: adrian.

okay, go ahead then!

This revision is now accepted and ready to land.Jan 14 2016, 12:43 AM
Closed by commit rS293874: hyperv: add interrupt counters (authored by sephe). · Explain WhyJan 14 2016, 3:12 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
hyperv/
vmbus/
17 lines
17 lines

Diff 12283

View Options

head/sys/dev/hyperv/vmbus/hv_connection.c

Loading...
View Options

head/sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c

Loading...