Extend EINVAL's description for rename(2) and open(2)
ClosedPublic
Actions

Authored by jlduran on Aug 27 2024, 2:40 AM.

Details

Reviewers

kib
se

Group Reviewers

manpages

Commits

rG02c23c3b5ac9: open(2): Extend EINVAL's description
rG33f58ac0795b: rename(2): Extend EINVAL's description
rGf5a37f8dd319: open(2): mandoc -T lint

Summary

rename.2: Extend EINVAL's description

On some file systems, the last component of the destination path can
contain invalid characters and return EINVAL.

PR: 281033

open.2: Extend EINVAL's description

If O_CREAT is specified, the last component of the path argument can
contain invalid characters, and return EINVAL on some file systems.

PR: 218033

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

jlduran created this revision.Aug 27 2024, 2:40 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 27 2024, 2:40 AM

jlduran requested review of this revision.Aug 27 2024, 2:40 AM

kib added inline comments.Aug 27 2024, 2:46 AM

lib/libsys/open.2
583	Usually we provide separate list entry for each cause. So I suggest to remove the 'or' and add yet another `.It Bq Er` there
lib/libsys/rename.2
258	Same, add new enumeration item for EINVAL.

kib added a reviewer: manpages.Aug 27 2024, 2:48 AM

Put the new EINVAL descriptions on separate list items.

jlduran marked 2 inline comments as done.Aug 27 2024, 3:10 AM

Note that no linting was performed on these man pages.

The useless Tn macros will also be removed, but:

mandoc: open.2:350:9: STYLE: referenced manual not found: Xr __acl_get_fd 2
mandoc: open.2:350:29: STYLE: referenced manual not found: Xr __acl_aclcheck_fd 2

Will not be removed, given those were recently introduced in 7a292504bad8467915f072f0576b2a07c76de1f5.