Differential D46049

nvme: widen nvme_qpair_manual_complete_request for better errors
ClosedPublic
Actions

Authored by imp on Jul 19 2024, 11:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 21, 1:03 PM

	Unknown Object (File)
	Fri, Nov 21, 1:02 PM

	Unknown Object (File)
	Fri, Nov 21, 1:02 PM

	Unknown Object (File)
	Fri, Nov 21, 12:56 PM

	Unknown Object (File)
	Sat, Nov 8, 12:51 AM

	Unknown Object (File)
	Thu, Nov 6, 3:40 AM

	Unknown Object (File)
	Oct 28 2025, 2:17 AM

	Unknown Object (File)
	Oct 28 2025, 2:16 AM

View All 59 Files

Subscribers

Details

Reviewers

jhb
mav
chs
chuck

Commits

rG123e29068ecf: nvme: widen nvme_qpair_manual_complete_request for better errors

Summary

Make nvme_qpair_manual_complete_request take dnr as well as a
print_on_error action. Make the status word computation common between
it and nvme_qpair_manual_complete_tracker. And print the error when
we are cancelling the I/O on failure, but not when we're filtering
the I/O after we've failed. Make it private again to nvme_qpair.c.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jul 19 2024, 11:04 PM

Herald added a subscriber: dab. · View Herald TranscriptJul 19 2024, 11:04 PM

imp requested review of this revision.Jul 19 2024, 11:04 PM

imp added a parent revision: D46048: nvme: Fail passthrough commands right away in failed state..

Harbormaster completed remote builds in B58743: Diff 141164.Jul 19 2024, 11:04 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 20 2024, 2:59 AM

Closed by commit rG123e29068ecf: nvme: widen nvme_qpair_manual_complete_request for better errors (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG123e29068ecf: nvme: widen nvme_qpair_manual_complete_request for better errors.

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvme/

3 lines

37 lines

Diff 141173

sys/dev/nvme/nvme_private.h

Loading...

sys/dev/nvme/nvme_qpair.c

Loading...