Page MenuHomeFreeBSD
Differential D46018

usr.sbin/ppp: correct SIOCDIFADDR{,_IN6} calls to use {,in6_}ifreq
ClosedPublic
Actions

Authored by def on Jul 18 2024, 2:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 4, 10:16 AM
Unknown Object (File)
Dec 3 2024, 5:06 PM
Unknown Object (File)
Dec 3 2024, 5:05 PM
Unknown Object (File)
Dec 3 2024, 5:05 PM
Unknown Object (File)
Nov 30 2024, 2:56 AM
Unknown Object (File)
Nov 2 2024, 12:15 AM
Unknown Object (File)
Oct 2 2024, 10:44 PM
Unknown Object (File)
Oct 1 2024, 9:55 AM
View All 19 Files
Subscribers
imp
jhb

Details

Reviewers
brooks
oshogbo
jhb
Commits
rG2ab551500190: usr.sbin/ppp: correct SIOCDIFADDR{,_IN6} calls to use {,in6_}ifreq
Summary

The SIOCDIFADDR{,_IN6} ioctls take an ifreq structure object, not an
ifaliasreq structure object, as their argument.

Obtained from: CheriBSD

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 58701
Build 55589: arc lint + arc unit

Event Timeline

def created this revision.Jul 18 2024, 2:59 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 18 2024, 2:59 PM
def requested review of this revision.Jul 18 2024, 2:59 PM
Harbormaster completed remote builds in B58701: Diff 141073.Jul 18 2024, 3:00 PM
def added a comment.EditedJul 18 2024, 3:00 PM

@brooks @oshogbo Do you have any suggestions who should review this? It is not clear to me based on the commit history.

brooks accepted this revision.Jul 18 2024, 7:39 PM
brooks added a subscriber: jhb.

I don't see any obvious reviewer candidates. Maybe @jhb?

It looks like the original author of this commit just misunderstood how SIOCDIFADDR* worked.

This revision is now accepted and ready to land.Jul 18 2024, 7:39 PM
jhb accepted this revision.Jul 19 2024, 3:18 PM

sbin/nos-tun/nos-tun.c and usr.sbin/uhsoctl/uhsoctl.c both have the same mistake

def added a comment.Jul 19 2024, 3:51 PM

Thanks for reviews!

In D46018#1049505, @jhb wrote:

sbin/nos-tun/nos-tun.c and usr.sbin/uhsoctl/uhsoctl.c both have the same mistake

Yes, these are covered in:
https://reviews.freebsd.org/D46019
https://reviews.freebsd.org/D46017

oshogbo accepted this revision.Jul 22 2024, 7:17 AM
Closed by commit rG2ab551500190: usr.sbin/ppp: correct SIOCDIFADDR{,_IN6} calls to use {,in6_}ifreq (authored by def). · Explain WhyJul 22 2024, 10:08 AM
This revision was automatically updated to reflect the committed changes.
def added a commit: rG2ab551500190: usr.sbin/ppp: correct SIOCDIFADDR{,_IN6} calls to use {,in6_}ifreq.

Revision Contents
Changeset List

PathSize
usr.sbin/
ppp/
50 lines

Diff 141073

View Options

usr.sbin/ppp/iface.c

Loading...