Page MenuHomeFreeBSD

bsd.progs.mk: Create directories first
ClosedPublic

Authored by cperciva on Mon, Jul 8, 4:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 16, 10:01 PM
Unknown Object (File)
Tue, Jul 16, 12:36 PM
Unknown Object (File)
Mon, Jul 15, 4:39 PM
Unknown Object (File)
Mon, Jul 15, 5:25 AM
Unknown Object (File)
Wed, Jul 10, 3:01 PM
Unknown Object (File)
Tue, Jul 9, 2:28 AM

Details

Summary

Order installdirs before the $p.install targets; this is necessary
when a user of <bsd.progs.mk> also creates the directory into which
the binaries are installed.

In particular, without this patch running make installworld -jN can
break when installing tests since the /usr/tests/foo/bar directories
are created during installworld; this has been causing the stable/14
weekly snapshot builds to intermittently fail for months.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Jul 10, 2:47 PM
This revision was automatically updated to reflect the committed changes.
share/mk/bsd.progs.mk
158

FWIW I tend to avoid putting things in .for loops if I can, also you need :
you could put this after the .endfor

.ORDER: installdirs ${PROGS:@p@$p.install@}

share/mk/bsd.progs.mk
158

Oh you just want to ensure installdirs done before $p.install but the later can run in parallel?
In that case you just need :