Page MenuHomeFreeBSD
Differential D45862

sound: Fix min/max rate for SNDCTL_AUDIOINFO and SNDCTL_ENGINEINFO
ClosedPublic
Actions

Authored by christos on Jul 3 2024, 7:10 PM.
Tags
None
Referenced Files
F93369600: D45862.id140532.diff
Mon, Sep 9, 4:49 AM
F93254563: D45862.id140641.diff
Sun, Sep 8, 12:13 PM
F93241131: D45862.id.diff
Sun, Sep 8, 9:48 AM
Unknown Object (File)
Sat, Sep 7, 6:52 PM
Unknown Object (File)
Sat, Sep 7, 9:35 AM
Unknown Object (File)
Mon, Sep 2, 4:54 PM
Unknown Object (File)
Sun, Sep 1, 7:23 PM
Unknown Object (File)
Thu, Aug 22, 7:59 AM
View All 21 Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Commits
rG95d3abff7375: sound: Fix min/max rate for SNDCTL_AUDIOINFO and SNDCTL_ENGINEINFO
rG86585210fd56: sound: Fix min/max rate for SNDCTL_AUDIOINFO and SNDCTL_ENGINEINFO
Summary

Since we allow feeding of any rate within the [feeder_rate_min,
feeder_rate_max] range, report this as the min/max rate as well. Only
exceptions are when we the device is opened in exclusive or bitperfect
mode.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Jul 3 2024, 7:10 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 3 2024, 7:10 PM
christos requested review of this revision.Jul 3 2024, 7:10 PM
Harbormaster completed remote builds in B58485: Diff 140532.Jul 3 2024, 7:10 PM
christos mentioned this in D45664: sound: Fix min/max sample rate assignment for VCHANs.Jul 3 2024, 7:10 PM
christos added inline comments.
sys/dev/sound/pcm/dsp.c
2125

I did this for AUDIOINFO since we can feed arbitrary rates to physical channels as well.

christos added inline comments.Jul 3 2024, 7:21 PM
sys/dev/sound/pcm/dsp.c
2125

Didn't get the EXCL and BITPERFECT cases into account. Uploading fixed diff in a sec.

christos updated this revision to Diff 140535.Jul 3 2024, 7:40 PM

Handle EXCLUSIVE and BITPERFECT cases.

Harbormaster completed remote builds in B58487: Diff 140535.Jul 3 2024, 7:40 PM
christos edited the summary of this revision. (Show Details)Jul 3 2024, 7:41 PM
christos added a comment.Jul 3 2024, 7:47 PM

sndstat_get_caps() probably also needs fixing, but I will do this in a separate patch.

dev_submerge.ch accepted this revision.Jul 4 2024, 3:23 PM

Looks good to me, in my tests with ossinfo this returns the expected sample rate values.

sys/dev/sound/pcm/dsp.c
2211–2213

I think this comment should be adapted on occasion.

This revision is now accepted and ready to land.Jul 4 2024, 3:23 PM
christos added inline comments.Jul 4 2024, 3:28 PM
sys/dev/sound/pcm/dsp.c
2211–2213

I think we could even get rid of it. It also exists in AUDIOINFO.

christos added a comment.Jul 4 2024, 4:00 PM
In D45862#1045693, @christos wrote:

sndstat_get_caps() probably also needs fixing, but I will do this in a separate patch.

D45872

Closed by commit rG86585210fd56: sound: Fix min/max rate for SNDCTL_AUDIOINFO and SNDCTL_ENGINEINFO (authored by christos). · Explain WhyJul 6 2024, 6:24 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG86585210fd56: sound: Fix min/max rate for SNDCTL_AUDIOINFO and SNDCTL_ENGINEINFO.
christos added a commit: rG95d3abff7375: sound: Fix min/max rate for SNDCTL_AUDIOINFO and SNDCTL_ENGINEINFO.Jul 10 2024, 4:49 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
20 lines

Diff 140641

View Options

sys/dev/sound/pcm/dsp.c

Loading...