Page MenuHomeFreeBSD
Differential D45662

sound: Get rid of snd_sb16 workaround in vchan_create()
ClosedPublic
Actions

Authored by christos on Jun 20 2024, 5:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 2, 3:34 PM
Unknown Object (File)
Mon, Mar 2, 9:05 AM
Unknown Object (File)
Mon, Mar 2, 2:57 AM
Unknown Object (File)
Sat, Feb 28, 11:45 PM
Unknown Object (File)
Thu, Feb 26, 1:47 PM
Unknown Object (File)
Sat, Feb 21, 2:54 AM
Unknown Object (File)
Fri, Feb 20, 11:04 AM
Unknown Object (File)
Thu, Feb 19, 10:12 AM
View All 87 Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Commits
rGde8161712e23: sound: Get rid of snd_sb16 workaround in vchan_create()
rGd6d4586b0b7e: sound: Get rid of snd_sb16 workaround in vchan_create()
Summary

The snd_sb16 driver was removed in 716924cb4832 ("Retire snd_sbc ISA
sound card driver").

While here, simplify sample rate assignment a bit.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Jun 20 2024, 5:16 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 20 2024, 5:16 PM
christos requested review of this revision.Jun 20 2024, 5:16 PM
Harbormaster completed remote builds in B58269: Diff 140042.Jun 20 2024, 5:16 PM
christos retitled this revision from sound: Simplify VCHAN sample rate assignment in vchan_create() to sound: Get rid of snd_sb16 workaround in vchan_create().Jun 22 2024, 6:51 PM
christos edited the summary of this revision. (Show Details)
markj added inline comments.Jun 24 2024, 5:10 PM
sys/dev/sound/pcm/vchan.c
783

Now we apply these bounds only if vchanspd was initially 0, whereas we didn't do that before. Why?

christos updated this revision to Diff 140187.Jun 24 2024, 5:34 PM
christos marked an inline comment as done.

Address Mark's comment.

Harbormaster completed remote builds in B58333: Diff 140187.Jun 24 2024, 5:34 PM
christos added inline comments.Jun 24 2024, 5:34 PM
sys/dev/sound/pcm/vchan.c
783

My bad.

markj accepted this revision.Jun 24 2024, 6:05 PM
This revision is now accepted and ready to land.Jun 24 2024, 6:05 PM
emaste accepted this revision.Jun 24 2024, 6:07 PM
dev_submerge.ch accepted this revision.Jun 27 2024, 2:49 PM
Closed by commit rGd6d4586b0b7e: sound: Get rid of snd_sb16 workaround in vchan_create() (authored by christos). · Explain WhyJul 6 2024, 6:24 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rGd6d4586b0b7e: sound: Get rid of snd_sb16 workaround in vchan_create().
christos added a commit: rGde8161712e23: sound: Get rid of snd_sb16 workaround in vchan_create().Jul 10 2024, 4:49 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
28 lines

Diff 140631

View Options

sys/dev/sound/pcm/vchan.c

Loading...