sound: Get rid of snd_sb16 workaround in vchan_create()
AcceptedPublic
Actions

Authored by christos on Thu, Jun 20, 5:16 PM.

Details

Reviewers

markj
emaste
dev_submerge.ch

Summary

The snd_sb16 driver was removed in 716924cb4832 ("Retire snd_sbc ISA
sound card driver").

While here, simplify sample rate assignment a bit.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58333
Build 55221: arc lint + arc unit

Event Timeline

christos created this revision.Thu, Jun 20, 5:16 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Jun 20, 5:16 PM

christos requested review of this revision.Thu, Jun 20, 5:16 PM

Harbormaster completed remote builds in B58269: Diff 140042.Thu, Jun 20, 5:16 PM

christos retitled this revision from sound: Simplify VCHAN sample rate assignment in vchan_create() to sound: Get rid of snd_sb16 workaround in vchan_create().Sat, Jun 22, 6:51 PM

christos edited the summary of this revision. (Show Details)

markj added inline comments.Mon, Jun 24, 5:10 PM

sys/dev/sound/pcm/vchan.c
783	Now we apply these bounds only if vchanspd was initially 0, whereas we didn't do that before. Why?

Address Mark's comment.

Harbormaster completed remote builds in B58333: Diff 140187.Mon, Jun 24, 5:34 PM

christos added inline comments.Mon, Jun 24, 5:34 PM

sys/dev/sound/pcm/vchan.c
783	My bad.

markj accepted this revision.Mon, Jun 24, 6:05 PM

This revision is now accepted and ready to land.Mon, Jun 24, 6:05 PM

emaste accepted this revision.Mon, Jun 24, 6:07 PM

dev_submerge.ch accepted this revision.Thu, Jun 27, 2:49 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

vchan.c

28 lines

Diff 140187

View Options

sound: Get rid of snd_sb16 workaround in vchan_create()AcceptedPublicActions