LinuxKPI: Add linux/nodemask.h
ClosedPublic
Actions

Authored by wulf on Jun 16 2024, 8:28 PM.

Details

Reviewers

Group Reviewers

linuxkpi

Commits

Summary

and dummy num_possible_nodes() implementation. We do not support NUMA
in LinuxKPI yet.

Sponsored by: Serenity Cyber Security, LLC
MFC after: 1 week

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58197
Build 55085: arc lint + arc unit

wulf requested review of this revision.Jun 16 2024, 8:28 PM

This revision is now accepted and ready to land.Jun 17 2024, 5:33 AM

bz requested changes to this revision.Jun 17 2024, 9:34 AM

bz added inline comments.

sys/compat/linuxkpi/common/include/linux/nodemask.h
35	Can you leave a pr_debug() call here (instead of the comment); that way it can become visible.

This revision now requires changes to proceed.Jun 17 2024, 9:34 AM

bz added inline comments.Jun 17 2024, 9:38 AM

sys/compat/linuxkpi/common/include/linux/nodemask.h
31	Also not entirely true; see compat/common/src/linux_domain.c There is one instance where we do seem to return the domain.

sys/compat/linuxkpi/common/include/linux/nodemask.h
35	Depending on when this function is used in DRM this could be annoying as hell.

bz added inline comments.Jun 17 2024, 9:45 AM

sys/compat/linuxkpi/common/include/linux/nodemask.h
35	Depending on when this function is used in DRM this could be annoying as hell. pr_debug is behind a sysctl and off by default and off unless we have a kernel compiled with options DEBUG (to my memory).

sys/compat/linuxkpi/common/include/linux/nodemask.h
35	Indeed, I've missed the sysctl, I'm good for using it then.

sys/compat/linuxkpi/common/include/linux/nodemask.h
35	I left a comment on the GitHub that we should have a consistent way to tag TODO items in the Linuxulator; I was thinking of something like a LKPITODO comment but it seems that `pr_debug("%s: TODO\n", __func__);` is indeed the typical incantation.