Page MenuHomeFreeBSD

LinuxKPI: Move linux/minmax.h content out of linux/kernel.h
ClosedPublic

Authored by wulf on Jun 2 2024, 3:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 8, 11:48 AM
Unknown Object (File)
Fri, Jun 7, 7:02 PM
Unknown Object (File)
Fri, Jun 7, 2:53 AM
Unknown Object (File)
Tue, Jun 4, 4:09 PM
Subscribers

Details

Summary

To match Linux and allow direct linux/minmax.h inclusion.

Sponsored by: Serenity Cyber Security, LLC
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

wulf requested review of this revision.Jun 2 2024, 3:27 PM
bz requested changes to this revision.Jun 2 2024, 3:42 PM
bz added inline comments.
sys/compat/linuxkpi/common/include/linux/minmax.h
8

Looking at the history these are wrong. based on the 3 commits which seem to make out the lines removed from kernel.h (2ca3cc51324c4, abb14a540f751, fe657d68f54b7) all by Hans Petter Selasky the additional lines should be:

+ * Copyright (c) 2013-2015 Mellanox Technologies, Ltd.
+ * Copyright (c) 2014-2015 Fran<C3><A7>ois Tigeot

2016:

Obtained from:  kmacy @
Sponsored by:   Mellanox Technologies

2025:

Sponsored by:   Mellanox Technologies

So iX and Panasas can go but Fran<C3><A7>ois Tigeot should be added.

Can you please double check that I didn't foobar that?

45

Is there a reason not to keep the "clamp" ones together?

This revision now requires changes to proceed.Jun 2 2024, 3:42 PM

Also should be UFT-8-ized e.g. François Tigeot

Add Melanox and François to authors

Keep iX Systems and Panasas as origin of some macroses e.g. min & max may be
tracked to original ofed import and I do not want dig deeper in history than
git blame output.

Move clamp in to clamp group to preserve traditional FreeBSD order of macros
rather than switch to Linux one.

This revision is now accepted and ready to land.Mon, Jun 3, 9:00 PM