Plug routetbl memory leaks on vnet shutdown
ClosedPublic
Actions

Authored by bz on Dec 12 2015, 2:16 PM.

Details

Reviewers

emaste
gnn

Commits

rS292601: Since r256624 we've been leaking routing table allocations

Summary

Since r256624 we've been leaking routing table allocations
on vnet enabled jail shutdown. Call the provided cleanup
routines for IPs to plug these leaks.

Sponsored by: The FreeBSD Foundation
MFC atfer: 2 weeks

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1601
Build 1607: arc lint + arc unit

Event Timeline

bz updated this revision to Diff 11171.Dec 12 2015, 2:16 PM

bz retitled this revision from to Plug routetbl memory leaks on vnet shutdown.

bz updated this object.

bz edited the test plan for this revision. (Show Details)

bz added reviewers: gnn, emaste.

Herald added a subscriber: imp. · View Herald TranscriptDec 12 2015, 2:16 PM

gnn accepted this revision.Dec 15 2015, 3:36 PM

gnn edited edge metadata.

This revision is now accepted and ready to land.Dec 15 2015, 3:36 PM

Closed by commit rS292601: Since r256624 we've been leaking routing table allocations (authored by bz). · Explain WhyDec 22 2015, 2:53 PM

This revision was automatically updated to reflect the committed changes.

kbowling added a subscriber: kbowling.Dec 23 2015, 9:19 AM

kbowling added inline comments.

head/sys/netinet6/in6_rmx.c
270 ↗	(On Diff #11585)	Did you intend to replace return(1)?

Fixed in follow-up commit r292654.

head/sys/netinet6/in6_rmx.c
270 ↗	(On Diff #11585)	Yes. For one thing the caller treats it as (void) so the return value doesn't matter at all, for the other thing, ... whoops. Now I see what you mean. Fixed in r292654.