Page MenuHomeFreeBSD

ftpd: stop using -g flag for /bin/ls
ClosedPublic

Authored by allanjude on May 21 2024, 10:45 PM.
Tags
None
Referenced Files
F86909320: D45291.diff
Thu, Jun 27, 8:01 AM
Unknown Object (File)
May 23 2024, 5:25 PM
Unknown Object (File)
May 23 2024, 5:25 PM
Unknown Object (File)
May 22 2024, 5:31 PM
Unknown Object (File)
May 22 2024, 12:28 PM
Subscribers

Details

Summary

ftpd: stop using -g flag for /bin/ls

In 3bfbb521 the behaviour of ls was changed such that -g was no longer
a noop for compatibility with BSD 4.3, but instead changed the output
of long mode to exclude the owner of the file and display only the
group.

Update how FTPd invokes ls to restore the previous behaviour

Reported-by: Andrew Fengler <andrew.fengler@scaleengine.com>
Reviewed-by: jrtc27, des, imp
MFC after: 3 days
Sponsored-by: ScaleEngine Inc.
Fixes: 3bfbb521fef5 ("ls: Improve POSIX compatibility for -g and -n.")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 21 2024, 10:46 PM
des added inline comments.
libexec/ftpd/ftpd.8
279

unrelated to this change but

Though please change your Fixes to be 3bfbb521fef5 ("ls: Improve POSIX compatibility for -g and -n.")

Update commit message as suggested by jrtc27

This revision now requires review to proceed.May 21 2024, 10:51 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 21 2024, 10:53 PM
This revision was automatically updated to reflect the committed changes.