Page MenuHomeFreeBSD
Differential D45291

ftpd: stop using -g flag for /bin/ls
ClosedPublic
Actions

Authored by allanjude on Tue, May 21, 10:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 23, 5:25 PM
Unknown Object (File)
Thu, May 23, 5:25 PM
Unknown Object (File)
Wed, May 22, 5:31 PM
Unknown Object (File)
Wed, May 22, 12:28 PM
Subscribers
imp

Details

Reviewers
jhb
minsoochoo0122_proton.me
des
jrtc27
imp
Commits
rGe20971500194: ftpd: stop using -g flag for /bin/ls
Summary

ftpd: stop using -g flag for /bin/ls

In 3bfbb521 the behaviour of ls was changed such that -g was no longer
a noop for compatibility with BSD 4.3, but instead changed the output
of long mode to exclude the owner of the file and display only the
group.

Update how FTPd invokes ls to restore the previous behaviour

Reported-by: Andrew Fengler <andrew.fengler@scaleengine.com>
Reviewed-by: jrtc27, des, imp
MFC after: 3 days
Sponsored-by: ScaleEngine Inc.
Fixes: 3bfbb521fef5 ("ls: Improve POSIX compatibility for -g and -n.")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

allanjude created this revision.Tue, May 21, 10:45 PM
Herald added a subscriber: imp. · View Herald TranscriptTue, May 21, 10:45 PM
allanjude requested review of this revision.Tue, May 21, 10:45 PM
Harbormaster completed remote builds in B57827: Diff 138869.Tue, May 21, 10:45 PM
imp accepted this revision.Tue, May 21, 10:46 PM
This revision is now accepted and ready to land.Tue, May 21, 10:46 PM
des accepted this revision.Tue, May 21, 10:47 PM
des added inline comments.
libexec/ftpd/ftpd.8
279

unrelated to this change but

jrtc27 accepted this revision.Tue, May 21, 10:47 PM

Though please change your Fixes to be 3bfbb521fef5 ("ls: Improve POSIX compatibility for -g and -n.")

jrtc27 added a comment.Tue, May 21, 10:47 PM

Oh and MFC after?

allanjude updated this revision to Diff 138870.Tue, May 21, 10:51 PM

Update commit message as suggested by jrtc27

This revision now requires review to proceed.Tue, May 21, 10:51 PM
Harbormaster completed remote builds in B57828: Diff 138870.Tue, May 21, 10:51 PM
allanjude edited the summary of this revision. (Show Details)Tue, May 21, 10:52 PM
This revision was not accepted when it landed; it landed in state Needs Review.Tue, May 21, 10:53 PM
Closed by commit rGe20971500194: ftpd: stop using -g flag for /bin/ls (authored by allanjude). · Explain Why
This revision was automatically updated to reflect the committed changes.
allanjude added a commit: rGe20971500194: ftpd: stop using -g flag for /bin/ls.

Revision Contents
Changeset List

PathSize
libexec/
ftpd/
4 lines
2 lines
2 lines

Diff 138871

View Options

libexec/ftpd/ftpcmd.y

Loading...
View Options

libexec/ftpd/ftpd.8

Loading...
View Options

libexec/ftpd/ftpd.c

Loading...