Page MenuHomeFreeBSD
Differential D45171

arm64: make SPE regs use ALT_NAME macro
ClosedPublic
Actions

Authored by zachary.leaf_arm.com on Mon, May 13, 9:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 17, 7:22 PM
Unknown Object (File)
Fri, May 17, 3:12 PM
Unknown Object (File)
Wed, May 15, 5:22 PM
Unknown Object (File)
Tue, May 14, 4:29 AM
Unknown Object (File)
Mon, May 13, 7:36 PM
Unknown Object (File)
Mon, May 13, 7:36 PM
Unknown Object (File)
Mon, May 13, 7:25 PM
Subscribers
emaste
imp

Details

Reviewers
andrew
manu
Group Reviewers
arm64
Commits
rGf7bdaa103eb8: arm64: make SPE regs use ALT_NAME macro
Summary

When the register is not defined in Armv8.0 i.e. added in a later
extension, like SPE added in v8.2, the alternative name format of:

S<op0>_<op1>_C<crn>_C<crm>_<op2>

should be used; otherwise, calls to {READ,WRITE}_SPECIALREG() will
fail.

Use the MRS_REG_ALT_NAME() macro for SPE changing hex to decimal as
required by the macro.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zachary.leaf_arm.com created this revision.Mon, May 13, 9:53 AM
Herald added a reviewer: manu. · View Herald TranscriptMon, May 13, 9:53 AM
Herald added subscribers: emaste, imp. · View Herald Transcript
zachary.leaf_arm.com requested review of this revision.Mon, May 13, 9:53 AM
Harbormaster completed remote builds in B57673: Diff 138461.Mon, May 13, 9:53 AM
zachary.leaf_arm.com added a child revision: D45172: arm64: add PMBSR_MSS_{BSC,FSC} status code field.Mon, May 13, 9:53 AM
andrew added inline comments.Mon, May 13, 11:35 AM
sys/arm64/include/armreg.h
1638

As with D45173 keep the existing MRS_REG macro and add a _REG one with MRS_REG_ALT_NAME

zachary.leaf_arm.com added inline comments.Mon, May 13, 12:55 PM
sys/arm64/include/armreg.h
1638

Would the non-_REG one ever actually be usable or useful in any way? Trying to understand the logic of keeping the existing ones. MRS_REG produces a 24 bit value e.g. 0x189ae0, the _ALT_NAME one S3_0_C9_C10_7.

andrew added inline comments.Mon, May 13, 1:30 PM
sys/arm64/include/armreg.h
1638

They are used in identcpu.c when we need to provide a common value across all CPUs. In this case they are unlikely to be used, but I'd prefer to keep the macro names consistent.

zachary.leaf_arm.com updated this revision to Diff 138480.Mon, May 13, 4:54 PM

As per review comments

Harbormaster completed remote builds in B57684: Diff 138480.Mon, May 13, 4:54 PM
andrew accepted this revision.Tue, May 14, 10:00 AM
This revision is now accepted and ready to land.Tue, May 14, 10:00 AM
Closed by commit rGf7bdaa103eb8: arm64: make SPE regs use ALT_NAME macro (authored by zachary.leaf_arm.com, committed by andrew). · Explain WhyFri, May 17, 3:12 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rGf7bdaa103eb8: arm64: make SPE regs use ALT_NAME macro.

Revision Contents
Changeset List

PathSize
sys/
arm64/
include/
132 lines

Diff 138651

View Options

sys/arm64/include/armreg.h

Loading...