tests/fusefs: fix all tests that depend on kern.maxphys
ClosedPublic
Actions

Authored by glebius on Thu, May 2, 3:06 AM.

Details

Reviewers

asomers
kib

Commits

rGe9b411d27333: tests/fusefs: fix all tests that depend on kern.maxphys

Summary

The tests try to read kern.maxphys sysctl into int value, while
unsigned long is required. Not sure when this was broken, seems like
since cd8537910406e.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Thu, May 2, 3:06 AM

Herald added a subscriber: imp. · View Herald TranscriptThu, May 2, 3:06 AM

glebius requested review of this revision.Thu, May 2, 3:06 AM

Harbormaster completed remote builds in B57535: Diff 138002.Thu, May 2, 3:06 AM

u_long

tests/sys/fs/fusefs/write.cc
182	This is getting close to a fence, and probably over it with custom maxphys setting.

In D45053#1027303, @kib wrote:

u_long

The whole test set doesn't use this style, that's why I used unsigned long. I'd leave this decision to Alan.

asomers added inline comments.Mon, May 6, 3:53 AM

tests/sys/fs/fusefs/write.cc
182	What do you mean by "fence"?

kib added inline comments.Mon, May 6, 4:01 AM

tests/sys/fs/fusefs/write.cc
182	I mean that it is not too far from the default MAXPHYS value, and since maxphys is the dynamic boot parameter, user might cause the maxhphys to exceed m_maxwrite unknowingly.