Page MenuHomeFreeBSD
Differential D44875

kasan: fix false-positive kasan_report upon thread reuse
ClosedPublic
Actions

Authored by khng on Apr 19 2024, 7:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 5, 9:25 PM
Unknown Object (File)
Sun, Mar 29, 5:24 PM
Unknown Object (File)
Sun, Mar 29, 3:52 AM
Unknown Object (File)
Tue, Mar 24, 10:52 AM
Unknown Object (File)
Tue, Mar 24, 1:06 AM
Unknown Object (File)
Mon, Mar 16, 2:42 AM
Unknown Object (File)
Thu, Mar 12, 4:12 PM
Unknown Object (File)
Wed, Mar 11, 8:07 PM
View All 92 Files
Subscribers
imp
olce

Details

Reviewers
markj
Commits
rG933490d3b6d4: kasan: fix false-positive kasan_report upon thread reuse
rG68a3a7fc9483: kasan: fix false-positive kasan_report upon thread reuse
Summary

In fork1(), if a thread is reused and thread_alloc_stack() is not
called, mark the reused thread's kstack pages clean in the KASAN shadow
buffer.

Sponsored by: Juniper Networks, Inc.
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

khng created this revision.Apr 19 2024, 7:15 PM
Herald added subscribers: olce, imp. · View Herald TranscriptApr 19 2024, 7:15 PM
khng requested review of this revision.Apr 19 2024, 7:15 PM
markj accepted this revision.Apr 19 2024, 7:17 PM
This revision is now accepted and ready to land.Apr 19 2024, 7:17 PM
Harbormaster completed remote builds in B57231: Diff 137413.Apr 19 2024, 7:17 PM
markj added a comment.Apr 19 2024, 7:18 PM

BTW, you could add

Reported by: syzbot+7841eb438247e5a7f6b0@syzkaller.appspotmail.com
Reported by: syzbot+d35497494d68b4859367@syzkaller.appspotmail.com
Closed by commit rG68a3a7fc9483: kasan: fix false-positive kasan_report upon thread reuse (authored by khng). · Explain WhyApr 19 2024, 7:19 PM
This revision was automatically updated to reflect the committed changes.
khng added a commit: rG68a3a7fc9483: kasan: fix false-positive kasan_report upon thread reuse.
khng added a commit: rG933490d3b6d4: kasan: fix false-positive kasan_report upon thread reuse.Apr 22 2024, 12:31 AM

Revision Contents
Changeset List

PathSize
sys/
kern/
5 lines

Diff 137415

View Options

sys/kern/kern_fork.c

Loading...