Page MenuHomeFreeBSD

adduser: Overhaul.
ClosedPublic

Authored by des on Fri, Apr 19, 12:19 PM.
Tags
None
Referenced Files
F84038032: D44863.diff
Sat, May 18, 11:42 AM
Unknown Object (File)
Mon, May 6, 3:43 PM
Unknown Object (File)
Fri, May 3, 8:14 AM
Unknown Object (File)
Fri, May 3, 8:13 AM
Unknown Object (File)
Fri, May 3, 8:13 AM
Unknown Object (File)
Mon, Apr 29, 8:14 AM
Unknown Object (File)
Sat, Apr 27, 8:54 PM
Unknown Object (File)
Fri, Apr 26, 3:59 PM
Subscribers

Details

Summary

Most importantly:

  • Make local variables local.
  • Avoid unsafe use of -a and -o operators in test expressions.
  • Remove a hack intended to ease the transition from Perl 22 years ago.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Fri, Apr 19, 12:19 PM
allanjude added a subscriber: allanjude.

About time the FreeBSD 4.x perl compat bits went away, especially since they were not actually providing compatibility.

This revision is now accepted and ready to land.Fri, Apr 19, 1:29 PM

Might want to also note that you've made a lot of variables local. I think that's a good change too, but best to note it or split it off into another commit.

This revision was automatically updated to reflect the committed changes.

LGTM. I flagged a few other optional nits.

usr.sbin/adduser/adduser.sh
62–63
67
265–266
357–358