Page MenuHomeFreeBSD
Differential D44863

adduser: Overhaul.
ClosedPublic
Actions

Authored by des on Apr 19 2024, 12:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 29, 2:25 PM
Unknown Object (File)
Wed, Apr 29, 2:15 PM
Unknown Object (File)
Wed, Apr 22, 12:23 PM
Unknown Object (File)
Wed, Apr 22, 3:06 AM
Unknown Object (File)
Sun, Apr 19, 6:33 PM
Unknown Object (File)
Sat, Apr 11, 12:15 PM
Unknown Object (File)
Tue, Apr 7, 1:37 PM
Unknown Object (File)
Tue, Apr 7, 9:08 AM
View All Files
Subscribers
allanjude
imp
jrm

Details

Reviewers
allanjude
Commits
rGb7a56907af0c: adduser: Overhaul.
rG4f4905b2ef1c: adduser: Overhaul.
rG170d0882903e: adduser: Overhaul.
Summary

Most importantly:

  • Make local variables local.
  • Avoid unsafe use of -a and -o operators in test expressions.
  • Remove a hack intended to ease the transition from Perl 22 years ago.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Apr 19 2024, 12:19 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 19 2024, 12:19 PM
des requested review of this revision.Apr 19 2024, 12:19 PM
Harbormaster completed remote builds in B57214: Diff 137384.Apr 19 2024, 12:19 PM
allanjude accepted this revision.Apr 19 2024, 1:29 PM
allanjude added a subscriber: allanjude.

About time the FreeBSD 4.x perl compat bits went away, especially since they were not actually providing compatibility.

This revision is now accepted and ready to land.Apr 19 2024, 1:29 PM
imp added a comment.Apr 19 2024, 2:17 PM

Might want to also note that you've made a lot of variables local. I think that's a good change too, but best to note it or split it off into another commit.

des edited the summary of this revision. (Show Details)Apr 19 2024, 2:50 PM
Closed by commit rG170d0882903e: adduser: Overhaul. (authored by des). · Explain WhyApr 19 2024, 3:14 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG170d0882903e: adduser: Overhaul..
jrm added a subscriber: jrm.Apr 19 2024, 3:26 PM

LGTM. I flagged a few other optional nits.

usr.sbin/adduser/adduser.sh
62–63
67
265–266
357–358
des added a commit: rG4f4905b2ef1c: adduser: Overhaul..Apr 29 2024, 10:15 AM
des added a commit: rGb7a56907af0c: adduser: Overhaul..Apr 29 2024, 10:34 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
adduser/
225 lines

Diff 137391

View Options

usr.sbin/adduser/adduser.sh

Loading...