Page MenuHomeFreeBSD

Enable L1SS handling on RPI4 pcib

Authored by on Apr 17 2024, 12:03 PM.
Referenced Files
Unknown Object (File)
Thu, Jul 11, 5:20 PM
Unknown Object (File)
Fri, Jun 28, 1:21 AM
Unknown Object (File)
Sat, Jun 22, 6:56 PM
Unknown Object (File)
Sat, Jun 22, 4:20 AM
Unknown Object (File)
Jun 16 2024, 8:54 AM
Unknown Object (File)
May 21 2024, 11:55 PM
Unknown Object (File)
May 21 2024, 11:18 PM
Unknown Object (File)
May 19 2024, 2:05 AM



Thanks to @kevans91 for pointing me in the right direction. FreeBSD had the same bug as Linux (see where the ultimate solution was to honor the brcm,enable-l1ss FDT property.

In current versions of the dtb files this property has been added by default.

Without this on many, many pcie addin cards the pcib will Serror when trying to assert the clreq# pin on the pcie bus. Many cards do not have these hooked up.

Test Plan

I have done the following

  1. Without the patch applied, attach non-RPI specific PCIe devices to the PCIe bus. Observe the Serror
  2. Apply the patch, observe that the Serror goes away, and the PCIe device works

Diff Detail

rG FreeBSD src repository
Lint Skipped
Tests Skipped

Event Timeline

emaste added inline comments.

how did you arrive at the need for this additional delay, out of curiosity?

Let's put all the reviews in the PR for this. It's usually a bad idea to do both and wastes my time having to deal with both unless there's a good reason.


No need to read the node here, just use ofw_bus_has_prop

I put all of the suggested changes in sorry for doubling up on phab and gb. I'm new here :) marked an inline comment as done.

Moved to github.