TCP HPTS: improve consistency
ClosedPublic
Actions

Authored by tuexen on Mar 27 2024, 2:06 PM.

Details

Reviewers

rrs
glebius
rscheff

Group Reviewers

transport

Commits

rGd341a5645144: tcp hpts: improve consistency
rG8375db082c6b: tcp hpts: improve consistency
rGb600644fdd6c: tcp hpts: improve consistency

Summary

The target_slot argument of max_slots_available() can be NULL. Therefore, check for this in all places.
Right now, all callers provide non-NULL pointer.

Reported by: Coverity Scan
CID: 1527732

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Mar 27 2024, 2:06 PM

Herald added a reviewer: transport. · View Herald TranscriptMar 27 2024, 2:06 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Mar 27 2024, 2:06 PM

rrs accepted this revision.Mar 31 2024, 11:50 AM

This revision is now accepted and ready to land.Mar 31 2024, 11:50 AM

Closed by commit rGb600644fdd6c: tcp hpts: improve consistency (authored by tuexen). · Explain WhyApr 1 2024, 7:57 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rGb600644fdd6c: tcp hpts: improve consistency.

tuexen added a commit: rG8375db082c6b: tcp hpts: improve consistency.Apr 17 2024, 1:52 PM

tuexen added a commit: rGd341a5645144: tcp hpts: improve consistency.Aug 1 2024, 8:29 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_hpts.c

3 lines

Diff 136419

View Options

TCP HPTS: improve consistencyClosedPublicActions