Page MenuHomeFreeBSD
Differential D4451

Added -t option to display field types on sysctl(8).
ClosedPublic
Actions

Authored by araujo on Dec 9 2015, 3:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 9:36 PM
Unknown Object (File)
Thu, Jan 2, 12:12 AM
Unknown Object (File)
Nov 19 2024, 8:54 PM
Unknown Object (File)
Nov 3 2024, 11:58 AM
Unknown Object (File)
Nov 3 2024, 11:57 AM
Unknown Object (File)
Nov 3 2024, 11:57 AM
Unknown Object (File)
Nov 3 2024, 11:57 AM
Unknown Object (File)
Nov 3 2024, 11:57 AM
View All Files
Subscribers
imp

Details

Reviewers
• rodrigc
cem
bapt
Group Reviewers
manpages
Commits
rS292045: Add -t option to display field types.
Summary

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203918

Added -t option to display field types. It may be used together with -d option.
This made easier to find field types when toying sysctls in systat.

Test Plan

DOCS: igor -R and mandoc -Tlint

sysctl(8):
sysctl -a -t
sysctl -dt security.jail.mount_allowed
sysctl -t security.jail.mount_allowed

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1499
Build 1505: arc lint + arc unit

Event Timeline

araujo updated this revision to Diff 10950.Dec 9 2015, 3:23 AM
araujo retitled this revision from to Added -t option to display field types on sysctl(8)..
araujo updated this object.
araujo edited the test plan for this revision. (Show Details)
araujo added reviewers: • rodrigc, bapt.
Herald added a reviewer: manpages. · View Herald TranscriptDec 9 2015, 3:23 AM
Herald added a subscriber: imp. · View Herald Transcript
araujo added a reviewer: cem.Dec 9 2015, 3:25 AM
cem accepted this revision.Dec 9 2015, 3:30 AM
cem edited edge metadata.

Looks good to me modulo minor nitpicks inline.

sbin/sysctl/sysctl.c
915

Use typename != NULL (for non-boolean types) rather than implicitly converting a pointer to bool.

917–919

Drop the comments, they're not helpful here.

This revision is now accepted and ready to land.Dec 9 2015, 3:30 AM
araujo updated this revision to Diff 10951.Dec 9 2015, 4:01 AM
araujo edited edge metadata.

Address @cem comments.
Please, @cem could you double review the changes with the typename?

Best,

This revision now requires review to proceed.Dec 9 2015, 4:01 AM
Herald edited edge metadata. · View Herald TranscriptDec 9 2015, 4:01 AM
araujo updated this revision to Diff 10952.Dec 9 2015, 4:04 AM
araujo edited edge metadata.

Fix an identation problem. My bad!

Herald edited edge metadata. · View Herald TranscriptDec 9 2015, 4:04 AM
cem accepted this revision.Dec 9 2015, 4:15 AM
cem edited edge metadata.

Looks good to me, thanks!

This revision is now accepted and ready to land.Dec 9 2015, 4:15 AM
bapt accepted this revision.Dec 9 2015, 12:40 PM
bapt edited edge metadata.
Closed by commit rS292045: Add -t option to display field types. (authored by araujo). · Explain WhyDec 10 2015, 2:12 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sbin/
sysctl/
8 lines
34 lines

Diff 10951

View Options

sbin/sysctl/sysctl.8

Loading...
View Options

sbin/sysctl/sysctl.c

Loading...