Page MenuHomeFreeBSD

Added -t option to display field types on sysctl(8).
ClosedPublic

Authored by araujo on Dec 9 2015, 3:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 9 2024, 7:10 AM
Unknown Object (File)
Mar 9 2024, 7:10 AM
Unknown Object (File)
Mar 9 2024, 7:10 AM
Unknown Object (File)
Mar 9 2024, 7:10 AM
Unknown Object (File)
Mar 9 2024, 7:10 AM
Unknown Object (File)
Mar 9 2024, 6:58 AM
Unknown Object (File)
Feb 23 2024, 10:45 PM
Unknown Object (File)
Feb 9 2024, 7:39 AM
Subscribers

Details

Summary

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203918

Added -t option to display field types. It may be used together with -d option.
This made easier to find field types when toying sysctls in systat.

Test Plan

DOCS: igor -R and mandoc -Tlint

sysctl(8):
sysctl -a -t
sysctl -dt security.jail.mount_allowed
sysctl -t security.jail.mount_allowed

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

araujo retitled this revision from to Added -t option to display field types on sysctl(8)..
araujo updated this object.
araujo edited the test plan for this revision. (Show Details)
araujo added reviewers: rodrigc, bapt.
cem edited edge metadata.

Looks good to me modulo minor nitpicks inline.

sbin/sysctl/sysctl.c
915 ↗(On Diff #10950)

Use typename != NULL (for non-boolean types) rather than implicitly converting a pointer to bool.

917–919 ↗(On Diff #10950)

Drop the comments, they're not helpful here.

This revision is now accepted and ready to land.Dec 9 2015, 3:30 AM
araujo edited edge metadata.

Address @cem comments.
Please, @cem could you double review the changes with the typename?

Best,

This revision now requires review to proceed.Dec 9 2015, 4:01 AM
araujo edited edge metadata.

Fix an identation problem. My bad!

cem edited edge metadata.

Looks good to me, thanks!

This revision is now accepted and ready to land.Dec 9 2015, 4:15 AM
bapt edited edge metadata.
This revision was automatically updated to reflect the committed changes.