Page MenuHomeFreeBSD

libsys: link symbolic
ClosedPublic

Authored by kib on Feb 22 2024, 9:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 20, 1:24 AM
Unknown Object (File)
Mon, Oct 20, 12:08 AM
Unknown Object (File)
Sat, Oct 18, 10:33 PM
Unknown Object (File)
Wed, Oct 15, 12:07 AM
Unknown Object (File)
Tue, Oct 14, 8:17 PM
Unknown Object (File)
Tue, Oct 14, 1:54 PM
Unknown Object (File)
Tue, Oct 14, 1:54 PM
Unknown Object (File)
Tue, Oct 14, 1:54 PM

Details

Summary

so that libc/libthr do not preempt libsys symbols, esp. errno-related

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib requested review of this revision.Feb 22 2024, 9:14 PM

To confirm I understand this:

  • Linking libsys.so without -Bsymbolic means the linker deems the various symbols preemptible
  • If libc.so is earlier in the link map then libsys's unfiltered symbols will be preempted by libc.so's at run time

I can conform this fixes the issues I've seen with an WITH_BIND_NOW jail.

This revision is now accepted and ready to land.Feb 22 2024, 11:53 PM

To confirm I understand this:

  • Linking libsys.so without -Bsymbolic means the linker deems the various symbols preemptible
  • If libc.so is earlier in the link map then libsys's unfiltered symbols will be preempted by libc.so's at run time

It also means that symbols looked up not _from the filter_ are preempted. This is the cause of the problem

This revision was automatically updated to reflect the committed changes.

This change breaks legacy programs that declare extern int errno; instead of including errno.h. Maybe we want to find a different solution.

In D44027#1066388, @fuz wrote:

This change breaks legacy programs that declare extern int errno; instead of including errno.h. Maybe we want to find a different solution.

See D46780 for a change that completes the removal of the errno symbol.