fdlopen(3): do not create a new object mapping if already loaded
ClosedPublic
Actions

Authored by kib on Feb 22 2024, 1:21 AM.

Details

Reviewers

emaste
markj

Commits

rG452c5e9995ab: fdlopen(3): do not create a new object mapping if already loaded

Summary

This is expected behavior for both dlopen(3) and fdlopen(3).

PR:     277169

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Feb 22 2024, 1:21 AM

Herald added subscribers: bdragon, imp. · View Herald TranscriptFeb 22 2024, 1:21 AM

kib requested review of this revision.Feb 22 2024, 1:21 AM

emaste accepted this revision.Feb 22 2024, 1:23 AM

This revision is now accepted and ready to land.Feb 22 2024, 1:23 AM

Any chance to add a test case so this doesn't break in the future?

Closed by commit rG452c5e9995ab: fdlopen(3): do not create a new object mapping if already loaded (authored by kib). · Explain WhyFeb 22 2024, 1:29 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG452c5e9995ab: fdlopen(3): do not create a new object mapping if already loaded.

In D44019#1004205, @vini.ipsmaker_gmail.com wrote:

Any chance to add a test case so this doesn't break in the future?

Would you provide a patch?

Would you provide a patch?

I haven't contributed code to FreeBSD yet, so this could be a good first patch. I can write code, but it'll take me some time to get a devenv ready to test my changes as I'm not yet used to FreeBSD development.

Revision Contents
Changeset List

Path

Size

libexec/

rtld-elf/

rtld.c

5 lines

Diff 134818

View Options

fdlopen(3): do not create a new object mapping if already loadedClosedPublicActions