Page MenuHomeFreeBSD

*/*: Properly depend on Subversion LTS or latest with WITH_SUBVERSION_VER
ClosedPublic

Authored by michaelo on Feb 13 2024, 2:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 8, 10:35 PM
Unknown Object (File)
Sat, Apr 6, 2:55 AM
Unknown Object (File)
Wed, Mar 27, 2:45 PM
Unknown Object (File)
Tue, Mar 19, 11:53 AM
Unknown Object (File)
Tue, Mar 19, 11:47 AM
Unknown Object (File)
Tue, Mar 19, 11:47 AM
Unknown Object (File)
Sun, Mar 17, 8:09 PM
Unknown Object (File)
Mar 4 2024, 3:36 PM
Subscribers
None

Details

Summary

When LTS version of Subversion is set in make.conf (WITH_SUBVERSION_VER)
depending ports will still depend on latest version (devel/subversion)
instead of LTS one (devel/subversion-lts). This will cause dependency
conflicts when packages are distributed with Poudriere, namely pkg(8)
will report them and fail to install.
Make all affected ports properly depend on the right port based on the
value set in WITH_SUBVERSION_VER.

Approved by: jrm (mentor), otis (mentor), lev

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michaelo created this revision.

Ran three sets in poudiere:

  1. no make.conf
  2. with latest
  3. with LTS

dependencies were calculated properly now.

Add additional reviewers as you think fit.

Note: I have explicitly removed 114 because every non-LTS version supersedes the previous non-LTS one. I highly doubt that anyone of us will maintain multiple non-LTS ports of Subversion.

Since this won't affect the official packages, and it's essentially the same as

.if ${PORT_OPTIONS:MBLAH}
RUN_DEPENDS+=	${LOCALBASE}/bin/bin:cat/port
.else
...
.endif

or

.if ${FLAVOR} == blah
LIB_DEPENDS+=	blah.so:cat/port
.else
...
.endif

it seems fine to me.

Let's give it a few days to see whether anyone else has objections.

This revision is now accepted and ready to land.Feb 13 2024, 8:47 PM

I will give @lev two weeks to review as demanded by the maintainer timeout. So I can merge around 2024-02-27.

@lev, one day left, do you want to take a peek?