Page MenuHomeFreeBSD

Add 14 new R ports
ClosedPublic

Authored by einar_isnic.is on Feb 4 2024, 1:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 3:59 PM
Unknown Object (File)
Sun, Apr 21, 10:08 AM
Unknown Object (File)
Sun, Apr 21, 8:58 AM
Unknown Object (File)
Sun, Apr 7, 3:15 AM
Unknown Object (File)
Sat, Apr 6, 2:53 PM
Unknown Object (File)
Fri, Apr 5, 8:55 AM
Unknown Object (File)
Tue, Apr 2, 9:17 AM
Unknown Object (File)
Mon, Mar 25, 10:38 PM

Details

Summary

graphics/R-cran-cowplot
devel/R-cran-tidyverse
databases/R-cran-dbplyr
databases/R-cran-dtplyr
devel/R-cran-conflicted
devel/R-cran-gargle
devel/R-cran-googledrive
devel/R-cran-googlesheets4
devel/R-cran-ids
devel/R-cran-modelr
devel/R-cran-systemfonts
graphics/R-cran-ragg
print/R-cran-textshaping

devel/R-cran-mockr
Test Plan

Ran portlint, built all with poudriere and ran test program in R

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

einar_isnic.is created this revision.
einar_isnic.is edited the test plan for this revision. (Show Details)
  • Add TEST_DEPENDS for graphics/R-cran-cowplot
  • Add dependencies for tests.
  • Update devel/R-cran-systemfonts to 1.0.6
  • Update graphics/R-cran-ragg to 1.3.0
arrowd added inline comments.
devel/R-cran-googlesheets4/pkg-descr
3 ↗(On Diff #135776)

This paragraph is not needed.

print/R-cran-textshaping/Makefile
7 ↗(On Diff #135776)

I don't think quotes are needed here and other places.

Mental note

primary ports:
graphics/R-cran-cowplot
devel/R-cran-tidyverse
databases/R-cran-dbplyr

devel/R-cran-gargle/Makefile
8 ↗(On Diff #133833)

Not a nice WWW url pointing to issues.
What about https://gargle.r-lib.org/ or R-cran package?

There are 14 ports to add, not 13. Please update review title.

databases/R-cran-dbplyr/        OK
databases/R-cran-dtplyr/        OK
devel/R-cran-conflicted/        MISS (fixed, added to devel/Makefile)
devel/R-cran-gargle/            OK
devel/R-cran-googledrive/       OK
devel/R-cran-googlesheets4/     OK
devel/R-cran-ids/               OK
devel/R-cran-mockr/             OK
devel/R-cran-modelr/            OK
devel/R-cran-systemfonts/       OK
devel/R-cran-tidyverse/         OK
graphics/R-cran-cowplot/        OK
graphics/R-cran-ragg/           OK
print/R-cran-textshaping/       OK
einar_isnic.is retitled this revision from Add 13 new R ports to Add 14 new R ports.Fri, Apr 5, 9:24 AM
einar_isnic.is edited the summary of this revision. (Show Details)

I've started adding ports and it will be single commits like:

commit: add port <cat>/<portname>: ...
(including entry to <cat>/Makefile)

I think this is more correct related to adding new ports to <cat>/Makefile's (it will facilitate a git revert if something is wrong)

Other thing, could we use DISTVERSION instead of PORTVERSION?

I've started adding ports and it will be single commits like:

commit x:

  • add port <cat>/<portname>: ...
  • add entry to <cat>/Makefile

I think this is more correct related to adding new ports to <cat>/Makefile's (it will facilitate a git revert if something is wrong)

Sounds good.

Other thing, could we use DISTVERSION instead of PORTVERSION?

Ok, I'll update the revision and switch to DISTVERSION

devel/R-cran-gargle/Makefile
8 ↗(On Diff #133833)

I looked at URL field on R-cran package, and I thought I had always preferred site other than github, but I guess not.

According to R-cran package, https://gargle.r-lib.org is the correct one

No need to update review diff. I'll do this.

devel/R-cran-gargle/Makefile
8 ↗(On Diff #133833)

fixed in commit

Fixed missing test depends and now all ports have successfull tests under poudriere jail.
Just finishing testports on 15, 140, 133 and 132 and we are ready to go.

Another issue not discussed here is about choosing WWW R cran packages URL due to it's simplicity instead of using upstream site.
This is a matter of personal taste, so if you decide going that way, please open a PR.
e.g.: https://cran.r-project.org/web/packages/xts/index.html

This revision was not accepted when it landed; it landed in state Needs Review.Sat, Apr 6, 2:53 PM
This revision was automatically updated to reflect the committed changes.