Page MenuHomeFreeBSD
Differential D43636

vm_phys: Add a vm_phys_seg_paddr_to_vm_page() helper
ClosedPublic
Actions

Authored by markj on Jan 28 2024, 2:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 29, 8:40 PM
Unknown Object (File)
Wed, Oct 29, 8:37 PM
Unknown Object (File)
Wed, Oct 29, 8:35 PM
Unknown Object (File)
Wed, Oct 29, 8:33 PM
Unknown Object (File)
Wed, Oct 29, 8:29 PM
Unknown Object (File)
Tue, Oct 28, 7:57 AM
Unknown Object (File)
Tue, Oct 21, 11:40 PM
Unknown Object (File)
Mon, Oct 20, 9:34 AM
View All Files
Subscribers
imp

Details

Reviewers
alc
dougm
kib
Commits
rG69cbb18746b6: vm_phys: Add a vm_phys_seg_paddr_to_vm_page() helper
Summary

No functional change intended.

Suggested by: alc

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 55664
Build 52553: arc lint + arc unit

Event Timeline

markj created this revision.Jan 28 2024, 2:36 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 28 2024, 2:36 PM
markj requested review of this revision.Jan 28 2024, 2:36 PM
Harbormaster completed remote builds in B55664: Diff 133460.Jan 28 2024, 2:36 PM
kib accepted this revision.Jan 28 2024, 5:05 PM
This revision is now accepted and ready to land.Jan 28 2024, 5:05 PM
alc accepted this revision.Jan 28 2024, 6:09 PM

Despite the long name, it's still two characters shorter than the original code. :-)

dougm accepted this revision.Jan 28 2024, 6:27 PM
dougm added inline comments.
sys/vm/vm_phys.c
941

This could be applied at vm_page.c:787, if it were visible there.

978

If could be used here, if the fields of vm_phys_fictitious_seg were reordered.

markj marked an inline comment as done.Jan 29 2024, 4:18 PM
markj added inline comments.
sys/vm/vm_phys.c
941

I made the function externally visible.

978

I think I'd prefer to leave this case as it is. If there were more instances of this pattern, I'd be more inclined to take the suggestion.

markj updated this revision to Diff 133501.Jan 29 2024, 4:33 PM
markj marked an inline comment as done.

Incorporate one of Doug's suggestions.

This revision now requires review to proceed.Jan 29 2024, 4:33 PM
Harbormaster completed remote builds in B55684: Diff 133501.Jan 29 2024, 4:34 PM
dougm accepted this revision.Jan 29 2024, 4:54 PM
This revision is now accepted and ready to land.Jan 29 2024, 4:54 PM
Closed by commit rG69cbb18746b6: vm_phys: Add a vm_phys_seg_paddr_to_vm_page() helper (authored by markj). · Explain WhyJun 14 2024, 1:24 AM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG69cbb18746b6: vm_phys: Add a vm_phys_seg_paddr_to_vm_page() helper.

Revision Contents
Changeset List

PathSize
sys/
vm/
29 lines

Diff 133460

View Options

sys/vm/vm_phys.c

Loading...