Page MenuHomeFreeBSD

LinuxKPI: 802.11: fix field order in ieee80211_key_conf
ClosedPublic

Authored by bz on Jan 28 2024, 12:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 2, 4:18 AM
Unknown Object (File)
Wed, Nov 26, 11:01 AM
Unknown Object (File)
Nov 7 2025, 3:32 AM
Unknown Object (File)
Oct 27 2025, 1:58 AM
Unknown Object (File)
Oct 14 2025, 8:35 PM
Unknown Object (File)
Oct 14 2025, 8:35 PM
Unknown Object (File)
Oct 14 2025, 8:35 PM
Unknown Object (File)
Oct 14 2025, 10:40 AM

Details

Summary

When adding the new field link_id to struct ieee80211_key_conf it
was erroneously placed at the of the struct; the zero-length (variable
sized) array for the key always needs to stay last.
Resort fields and add hopefully helpful comment to avoid the problem
in the future.

Fixes: adff403fe7a87
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 55662
Build 52551: arc lint + arc unit

Event Timeline

bz requested review of this revision.Jan 28 2024, 12:57 AM

Good catch!

Please correct the summary:

When adding the new field link_id to struct ieee80211_key_conf it
was erroneously placed at the of the struct;

to
When adding the new field link_id to struct ieee80211_key_conf, it
was erroneously placed at the end of the struct.

This revision is now accepted and ready to land.Feb 1 2024, 3:13 PM