Page MenuHomeFreeBSD

LinuxKPI: 802.11: fix field order in ieee80211_key_conf
ClosedPublic

Authored by bz on Jan 28 2024, 12:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 16, 2:31 AM
Unknown Object (File)
Thu, Jun 11, 10:48 PM
Unknown Object (File)
Wed, Jun 10, 5:12 PM
Unknown Object (File)
Sat, May 30, 9:15 AM
Unknown Object (File)
Fri, May 29, 12:05 PM
Unknown Object (File)
Mon, May 25, 11:51 AM
Unknown Object (File)
May 14 2026, 4:00 PM
Unknown Object (File)
May 12 2026, 2:11 PM

Details

Summary

When adding the new field link_id to struct ieee80211_key_conf it
was erroneously placed at the of the struct; the zero-length (variable
sized) array for the key always needs to stay last.
Resort fields and add hopefully helpful comment to avoid the problem
in the future.

Fixes: adff403fe7a87
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz requested review of this revision.Jan 28 2024, 12:57 AM

Good catch!

Please correct the summary:

When adding the new field link_id to struct ieee80211_key_conf it
was erroneously placed at the of the struct;

to
When adding the new field link_id to struct ieee80211_key_conf, it
was erroneously placed at the end of the struct.

This revision is now accepted and ready to land.Feb 1 2024, 3:13 PM