Page MenuHomeFreeBSD
Differential D43512

net80211: make sure calls to (*iv_update_bss)() are locked
ClosedPublic
Actions

Authored by bz on Jan 19 2024, 5:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 9, 5:39 AM
Unknown Object (File)
Mar 2 2024, 4:43 PM
Unknown Object (File)
Feb 26 2024, 7:37 PM
Unknown Object (File)
Feb 19 2024, 10:15 PM
Unknown Object (File)
Feb 3 2024, 1:56 PM
Unknown Object (File)
Jan 28 2024, 7:34 PM
Unknown Object (File)
Jan 26 2024, 7:20 PM
Unknown Object (File)
Jan 22 2024, 9:28 PM
View All 9 Files
Subscribers
glebius
imp
melifaro
wireless

Details

Reviewers
adrian
cc
Commits
rGeecf453c0e56: net80211: make sure calls to (*iv_update_bss)() are locked
rGf8ec03794357: net80211: make sure calls to (*iv_update_bss)() are locked
rG383cbcd21b73: net80211: make sure calls to (*iv_update_bss)() are locked
rG49619f73151a: net80211: make sure calls to (*iv_update_bss)() are locked
Summary

It turned out thare various calls into (*iv_update_bss)(), that is
direct changes to vap->iv_bss in the old days, happened without
synchronisation.

Use locking assertions to document the requirement or status quo
at some callers given ic locking will eventually have to be dealt
with.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz created this revision.Jan 19 2024, 5:07 PM
Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptJan 19 2024, 5:07 PM
bz requested review of this revision.Jan 19 2024, 5:07 PM
Harbormaster completed remote builds in B55498: Diff 133037.Jan 19 2024, 5:07 PM
cc accepted this revision.Jan 23 2024, 5:22 PM
This revision is now accepted and ready to land.Jan 23 2024, 5:22 PM
cc added a comment.Jan 23 2024, 8:43 PM

By the way, I forgot to ask, is it also helpful to add IEEE80211_LOCK_ASSERT in lkpi_iv_update_bss()?

Closed by commit rG49619f73151a: net80211: make sure calls to (*iv_update_bss)() are locked (authored by bz). · Explain WhyFeb 3 2024, 1:57 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rG49619f73151a: net80211: make sure calls to (*iv_update_bss)() are locked.
bz added a commit: rG383cbcd21b73: net80211: make sure calls to (*iv_update_bss)() are locked.Feb 18 2024, 9:12 PM
bz added a commit: rGf8ec03794357: net80211: make sure calls to (*iv_update_bss)() are locked.Feb 19 2024, 8:09 AM
bz added a commit: rGeecf453c0e56: net80211: make sure calls to (*iv_update_bss)() are locked.Feb 19 2024, 4:10 PM

Revision Contents
Changeset List

PathSize
sys/
net80211/
15 lines
2 lines

Diff 133794

View Options

sys/net80211/ieee80211_node.c

Loading...
View Options

sys/net80211/ieee80211_proto.c

Loading...