Page MenuHomeFreeBSD

libc: Centralize non-building of sbrk stubs
ClosedPublic

Authored by brooks on Dec 21 2023, 7:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 4, 3:49 PM
Unknown Object (File)
Sat, Aug 31, 1:47 PM
Unknown Object (File)
Aug 2 2024, 11:58 AM
Unknown Object (File)
Jul 12 2024, 9:57 PM
Unknown Object (File)
Jul 12 2024, 9:55 PM
Unknown Object (File)
Jul 12 2024, 9:55 PM
Unknown Object (File)
Jul 12 2024, 9:55 PM
Unknown Object (File)
Jul 5 2024, 5:12 PM
Subscribers

Details

Summary

The actual implementation of sbrk(2) is on top of the undocumented
break(2) system call. On powerpc* this means we don't build _sbrk and
__sys_sbrk which were neither used nor exposed for linkage. Otherwise
it is a no-op.

The addition to lib/libc/sys/Makefile.inc is a direct commit to
stable/14 in lieu of merging the removal of the sbrk and sstk syscalls.

(cherry picked from commit 7893419d492c40ca82b68fca3dcc0f5f7047d39b)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This is intended to allow me to merge some other cleanups to stable/14 without merging the syscall removal which I don't want to fully merge even if it's unlikely to cause any problems.

Is this a commit to stable/14?

In D43159#983642, @kib wrote:

Is this a commit to stable/14?

Yes, this is intended for stable/14 as a partial MFC of rG7893419d492c40ca82b68fca3dcc0f5f7047d39b

This revision is now accepted and ready to land.Dec 22 2023, 2:12 PM
This revision was automatically updated to reflect the committed changes.