pflow: Turn `pflowstats' statistics counters into per-CPU counters to make them mpsafe.
ClosedPublic
Actions

Authored by kp on Dec 19 2023, 10:07 AM.

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rG2be6f75707b4: pflow: Turn `pflowstats' statistics counters into per-CPU counters to make them…

Summary

The weird interactions around pflow_flows' and sc_gcounter' replaced
by simple `pflow_flows' increment. Since the flow sequence is the 32
bits integer, the `sc_gcounter' type replaced by the type of uint32_t.

Obtained from: OpenBSD
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Dec 19 2023, 10:07 AM

Herald added subscribers: glebius, melifaro, farrokhi and 2 others. · View Herald TranscriptDec 19 2023, 10:07 AM

kp requested review of this revision.Dec 19 2023, 10:07 AM

Harbormaster completed remote builds in B55023: Diff 131570.Dec 19 2023, 10:07 AM

kp added a parent revision: D43115: pf tests: verify pflow over IPv6.Dec 19 2023, 10:07 AM

kp added a child revision: D43117: pf tests: test pflow NAT state information.

rebase

Harbormaster completed remote builds in B55313: Diff 132464.Jan 8 2024, 11:37 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 16 2024, 8:55 AM

Closed by commit rG2be6f75707b4: pflow: Turn `pflowstats' statistics counters into per-CPU counters to make them… (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG2be6f75707b4: pflow: Turn `pflowstats' statistics counters into per-CPU counters to make them….

Revision Contents
Changeset List

Path

Size

sys/

net/

pflow.h

2 lines

netpfil/

pf/

pflow.c

76 lines

Diff 132827

View Options

sys/net/pflow.h