Page MenuHomeFreeBSD

ufs: Update *eofflag upon a read of an unlinked directory
ClosedPublic

Authored by markj on Dec 18 2023, 9:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 22, 7:10 PM
Unknown Object (File)
Fri, May 22, 7:10 PM
Unknown Object (File)
Tue, May 12, 2:52 PM
Unknown Object (File)
Tue, May 12, 1:29 AM
Unknown Object (File)
Tue, May 12, 12:52 AM
Unknown Object (File)
Wed, Apr 29, 9:29 PM
Unknown Object (File)
Wed, Apr 29, 10:41 AM
Unknown Object (File)
Wed, Apr 29, 1:10 AM
Subscribers

Details

Summary

If the directory is unlinked, no further entries will be returned, but
we return no error. At least one caller (vn_dir_next_dirent()) asserts
that a VOP_READDIR call which returns no error and no entries will set
*eofflag != 0, so the current behaviour of UFS can trigger an assertion
failure.

Simply set *eofflag in this scenario.

Reported by: syzkaller

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable