Page MenuHomeFreeBSD
Differential D43089

ufs: Update *eofflag upon a read of an unlinked directory
ClosedPublic
Actions

Authored by markj on Dec 18 2023, 9:15 PM.
Tags
None
Referenced Files
F171165094: D43089.id.diff
Wed, Sep 9, 4:11 AM
Unknown Object (File)
Sun, Sep 6, 5:31 AM
Unknown Object (File)
Sun, Sep 6, 2:37 AM
Unknown Object (File)
Sun, Sep 6, 1:56 AM
Unknown Object (File)
Sat, Sep 5, 12:03 PM
Unknown Object (File)
Sat, Sep 5, 10:57 AM
Unknown Object (File)
Sat, Sep 5, 7:33 AM
Unknown Object (File)
Thu, Sep 3, 11:54 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
mckusick
olce
Commits
rGb525eaaa4aaf: ufs: Update *eofflag upon a read of an unlinked directory
rG3e36ef48a063: ufs: Update *eofflag upon a read of an unlinked directory
rG3ff574c5e1d1: ufs: Update *eofflag upon a read of an unlinked directory
Summary

If the directory is unlinked, no further entries will be returned, but
we return no error. At least one caller (vn_dir_next_dirent()) asserts
that a VOP_READDIR call which returns no error and no entries will set
*eofflag != 0, so the current behaviour of UFS can trigger an assertion
failure.

Simply set *eofflag in this scenario.

Reported by: syzkaller

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
ufs/
ufs/
4 lines

Diff 131686

View Options

sys/ufs/ufs/ufs_vnops.c

Loading...