Page MenuHomeFreeBSD

ldconfig: only configure compat32 when kernel supports it
ClosedPublic

Authored by kib on Nov 18 2023, 10:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 23, 3:03 PM
Unknown Object (File)
Sun, Jun 23, 8:15 AM
Unknown Object (File)
Thu, Jun 20, 9:58 PM
Unknown Object (File)
Fri, Jun 14, 7:59 AM
Unknown Object (File)
May 22 2024, 6:38 PM
Unknown Object (File)
May 9 2024, 12:17 AM
Unknown Object (File)
May 3 2024, 9:50 PM
Unknown Object (File)
Apr 29 2024, 7:22 AM
Subscribers

Details

Summary

This depends on D42641. The patch eliminates hard-coded list of arches.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib requested review of this revision.Nov 18 2023, 10:00 PM

Use compat_freebsd32 name

I'd consider using the old name (i.e., compat_freebsd_32bit), just to be a bit friendlier to older kernels even though that's not supported.

libexec/rc/rc.d/ldconfig
42
This revision is now accepted and ready to land.Nov 20 2023, 2:32 PM
kib marked an inline comment as done.Nov 20 2023, 10:26 PM

I'd consider using the old name (i.e., compat_freebsd_32bit), just to be a bit friendlier to older kernels even though that's not supported.

If old kernel is used, the consequence is only a stray error message about unknown ELF brand. IMO it is not worth leaving the old name around in script, esp. if it is removed some day.

markj requested changes to this revision.Nov 21 2023, 3:17 AM
This revision now requires changes to proceed.Nov 21 2023, 3:17 AM

So you insist on using the old feature name?

In D42669#974121, @kib wrote:

So you insist on using the old feature name?

I don't, it was a misclick.

This revision is now accepted and ready to land.Nov 24 2023, 4:35 PM