Differential D42583

pkg: Use a global buffer for local ABI string
AbandonedPublic
Actions

Authored by jhb on Nov 13 2023, 10:30 PM.

Tags

None

Referenced Files

	F154886340: D42583.id.diff
	Wed, Apr 29, 7:04 PM

	Unknown Object (File)
	Tue, Apr 28, 9:22 PM

	Unknown Object (File)
	Tue, Apr 28, 9:13 PM

	Unknown Object (File)
	Sun, Apr 26, 1:43 AM

	Unknown Object (File)
	Tue, Apr 14, 10:49 PM

	Unknown Object (File)
	Sat, Apr 11, 12:37 PM

	Unknown Object (File)
	Wed, Apr 8, 4:02 PM

	Unknown Object (File)
	Tue, Apr 7, 10:48 PM

View All 88 Files

Subscribers

Details

Reviewers

emaste
bdrewery
bapt
imp

Summary

Otherwise c[ABI].val can point to a no-longer-valid on-stack buffer
after config_init returns.

Reported by: GCC 13 -Wdangling-pointer

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 54407
Build 51297: arc lint + arc unit

Event Timeline

jhb created this revision.Nov 13 2023, 10:30 PM

Herald added a reviewer: bdrewery. · View Herald TranscriptNov 13 2023, 10:30 PM

Herald added a subscriber: imp. · View Herald Transcript

jhb requested review of this revision.Nov 13 2023, 10:30 PM

Harbormaster completed remote builds in B54407: Diff 130056.Nov 13 2023, 10:30 PM

jhb added a parent revision: D42582: snmp_wlan: Fix a couple of type mismatches in function prototypes.Nov 13 2023, 10:30 PM

jhb added a child revision: D42584: ath_hal: Fix a couple of type mismatches in function prototypes.

jhb added a reviewer: bapt.Nov 13 2023, 10:31 PM

imp accepted this revision.Nov 14 2023, 12:24 AM

This revision is now accepted and ready to land.Nov 14 2023, 12:24 AM

OK with me, or we could have pkg_get_myabi asprintf it?

bapt accepted this revision.Nov 14 2023, 8:34 AM

In D42583#971581, @emaste wrote:

OK with me, or we could have pkg_get_myabi asprintf it?

I don't know that we really need that extra complexity TBH. But alternatively, yes, I would make pkg_get_myabi() return an allocated string that the caller has to manage the lifetime of.

Actually, I like the asprintf version better, so I will upload that in a bit.

Sorry for making more work for you :)

jhb mentioned this in D42623: pkg: Allocate a suitably-sized string for the local ABI.Nov 15 2023, 6:38 PM

jhb abandoned this revision.Nov 16 2023, 12:55 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

pkg/

2 lines

Diff 130056

usr.sbin/pkg/config.c

Loading...