Page MenuHomeFreeBSD

pkg: Allocate a suitably-sized string for the local ABI
ClosedPublic

Authored by jhb on Nov 15 2023, 6:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 12, 2:38 PM
Unknown Object (File)
Wed, Aug 12, 1:25 PM
Unknown Object (File)
Tue, Aug 11, 3:04 PM
Unknown Object (File)
Tue, Aug 11, 3:02 PM
Unknown Object (File)
Mon, Aug 10, 10:08 AM
Unknown Object (File)
Mon, Aug 10, 2:24 AM
Unknown Object (File)
Sat, Aug 8, 3:35 AM
Unknown Object (File)
Wed, Aug 5, 8:34 AM
Subscribers

Details

Summary

Previously the local ABI string was written to an on-stack buffer and
the pointer to that buffer was saved in a global before the function
returned. This had two issues: c[ABI].val pointed to a
no-longer-valid on-stack buffer after config_init returned, and the
string could potentially be truncated. Fix both of those by changing
pkg_get_myabi to return a pointer to a string allocated by asprintf.

Reported by: GCC 13 -Wdangling-pointer

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable