Page MenuHomeFreeBSD
Differential D42623

pkg: Allocate a suitably-sized string for the local ABI
ClosedPublic
Actions

Authored by jhb on Nov 15 2023, 6:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 1, 11:23 AM
Unknown Object (File)
Wed, Oct 1, 2:02 AM
Unknown Object (File)
Tue, Sep 23, 1:17 AM
Unknown Object (File)
Fri, Sep 19, 9:55 PM
Unknown Object (File)
Wed, Sep 17, 2:32 PM
Unknown Object (File)
Sat, Sep 13, 9:18 PM
Unknown Object (File)
Sat, Sep 13, 4:52 PM
Unknown Object (File)
Aug 15 2025, 4:12 PM
View All 68 Files
Subscribers
imp

Details

Reviewers
emaste
bapt
bdrewery
Commits
rGa979d6f59919: pkg: Allocate a suitably-sized string for the local ABI
rG2012748bd723: pkg: Allocate a suitably-sized string for the local ABI
rGfd9ae9ac04ed: pkg: Allocate a suitably-sized string for the local ABI
Summary

Previously the local ABI string was written to an on-stack buffer and
the pointer to that buffer was saved in a global before the function
returned. This had two issues: c[ABI].val pointed to a
no-longer-valid on-stack buffer after config_init returned, and the
string could potentially be truncated. Fix both of those by changing
pkg_get_myabi to return a pointer to a string allocated by asprintf.

Reported by: GCC 13 -Wdangling-pointer

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
usr.sbin/
pkg/
21 lines

Diff 130188

View Options

usr.sbin/pkg/config.c

Loading...