fflush: correct buffer handling in __sflush
ClosedPublic
Actions

Authored by emaste on Nov 7 2023, 2:56 PM.

Details

Reviewers

jhb
markj
kib
des

Commits

rG0b7939d725ba: fflush: correct buffer handling in __sflush
rGd2c65a1c9486: fflush: correct buffer handling in __sflush
rG4e0e01bf6511: fflush: correct buffer handling in __sflush

Summary

Two additional stdio changes followed 86a16ada1ea6 and need to be
reverted as part of the fflush fix.

This reverts commit 6e13794fbe6e82c21365d0fd66769bf8b19c0197.
This reverts commit bafaa70b6f9098d83d074968c8e6747ecec1e118.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Nov 7 2023, 2:56 PM

emaste created this revision.

With this change there are only trivial differences between stable/12, stable/13, stable/14, and main in the three affected files
lib/libc/stdio/fflush.c
lib/libc/stdio/fvwrite.c
lib/libc/stdio/wbuf.c.

Changes are $FreeBSD$ removal and a style change (if (__fflush(fp) != 0) vs if (__fflush(fp))).
(also a leftover #include of errno.h which was missed in the revert)

markj accepted this revision.Nov 7 2023, 4:02 PM

This revision is now accepted and ready to land.Nov 7 2023, 4:02 PM

Closed by commit rG4e0e01bf6511: fflush: correct buffer handling in __sflush (authored by emaste). · Explain WhyNov 7 2023, 5:28 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG4e0e01bf6511: fflush: correct buffer handling in __sflush.

Herald added a subscriber: imp. · View Herald TranscriptNov 7 2023, 5:28 PM

emaste added a commit: rGd2c65a1c9486: fflush: correct buffer handling in __sflush.Nov 7 2023, 5:59 PM

emaste added a commit: rG0b7939d725ba: fflush: correct buffer handling in __sflush.Nov 7 2023, 6:45 PM